TrinityCore icon indicating copy to clipboard operation
TrinityCore copied to clipboard

Core/Gossip: gossip_menu_option new params

Open offl opened this issue 7 months ago • 2 comments

Description

We need the following columns in gossip_menu_option:

  1. SpellID (spell to cast on player when gossip option is selected)
  2. IsTriggered (cast spell with triggered cast flag if set to 1 (needed for some spells))
  3. AutoClose (close gossip menu automatically after gossip is selected, if set to 1)

This is based on the following facts:

  1. On retail there's no AI hook OnGossipSelect
  2. On retail there's no action in AIGroup to close gossip
  3. I did some research back in the days and there are signs that gossip scripts are scripted by calling GameEvent. I don't remember details
  4. There is an enum in EnumeratedStrings that contains flags like 'Cast' and 'Start Pet Battle' or something like that, I don't remember correct names

Expected behaviour

above

Steps to reproduce the problem

none

Branch

3.3.5

TC rev. hash/commit

a1814cf13d24e7bb5142417a6f8f0dfd08db72e1

Operating system

Win 11

Custom changes

none

offl avatar May 08 '25 13:05 offl

is this not exactly what Smart Scripting was invented for

though DB mentions type 4 isnt supported (yet)

SMART_SCRIPT_TYPE_GOSSIP

AlexVermeulenGG avatar Nov 06 '25 09:11 AlexVermeulenGG

This script type will be a bad decision What I'm suggesting is exactly how it is implemented on retail

offl avatar Nov 06 '25 15:11 offl