TrinityCore icon indicating copy to clipboard operation
TrinityCore copied to clipboard

DB/Creatures: detach non-wdb data from creature_template part 1: difficulty entries

Open Ovahlord opened this issue 1 year ago • 4 comments

Changes proposed: this marks the beginning of a long overdue task: relocating data which isn't sent in query packets for creatures into separate tables. This means that when this journey is over, we can call creature_template sacred so no user may touch the table ever again just like we do with gameobject_template.

Tests performed:

  • none yet.

Ovahlord avatar Apr 27 '23 19:04 Ovahlord

I actually disagree with tiny splits like what you propose here for 1:1 relations, it makes dealing with tables very annoying

Shauren avatar Apr 27 '23 19:04 Shauren

Well, i'm currently thinking about migrating difficulty into creature_template_addon to get closer to what gameobject_template does and only create a new table for stats (level, faction, speeds etc) instead. the main goal in the end is to have a table with clean wdb data like we do have with quest_template and gameobject_template. creature_template is the only table which falls out of this pattern

Ovahlord avatar Apr 27 '23 20:04 Ovahlord

isn't it best to move it into creature_template_difficulty instead? _addon table should resemble as much as master's, and master's difficulties are handled in _scaling table which is non-existent in wotlk branches, this would be the counterpart to _scaling table.

Nyr97 avatar Apr 27 '23 20:04 Nyr97

IMO creature_template should only contain data from QUERY_RESPONSE and any other data taken from UFs or else should go to addon

funjoker avatar May 12 '23 17:05 funjoker