TrinityCore icon indicating copy to clipboard operation
TrinityCore copied to clipboard

Scripts/Silverpine: The Sepulcher's fixes

Open Nyr97 opened this issue 2 years ago • 2 comments

Note: nopch build will fail because it requires some of the previous PR's to be merged since there are enums in there that are used here. I will forcepush this branch when they get merged.

Changes proposed:

  • Added several pathings, gossip_menu, auras, vendorOptions and sAI in The Sepulcher.
  • Added visibility checks for Silverpine Forest's questline continuation.
  • Corrected many creatures' spawns and _addons in Olsen's Farthing.
  • Added support to add Excising the Tint (questId 27181) on players.
  • Quest fixes:
  • [x] Honor the Dead (questId 27180).
  • [x] Excising the Taint (questId 27181).
  • [x] Seek and Destroy (questId 27193).

Issues addressed:

None.

Tests performed:

It builds and it was tested in-game.

Known issues and TODO list: (add/remove lines as needed)

  • [ ] Pooling of npcs for Honor the Dead
  • [x] Fix lantern target for Seek and Destroy

Nyr97 avatar Oct 08 '22 17:10 Nyr97

Updates to the feedback:

Honor the Dead (questId 27180):

  • Gold looting should be fixed in a different PR since it's part of how SPELL_EFFECT_PICKPOCKET works to generate gold. As of now, I'm not sure if there's any type of condition elsewhere, but I'd take a guess and say only rogue's Pick Pocket (spellId 921) should be generating gold at all.
  • I have confirmed now that spawns are pooled. I will sniff every day until no new spawns show up.

Seek and Destroy (questId 27193):

  • I haven't figured out why the dynobject is not spawning regardless of hitting the target or not with EFFECT_0. I'll check packets and debug tomorrow.

Cornered and Crushed! (questId 27194):

  • Spawns to reward the quest will be moved to the next PR since it's a large RP event.

Misc:

  • Items sold by npcId 3551 seem to be correct.
  • Items sold by npcId 9553 were corrected.
  • Items sold by npcId 5757 had their slot corrected.

Nyr97 avatar Oct 25 '22 02:10 Nyr97

Missing: moving spawns to pool generation and finding out why the lantern won't show up.

Nyr97 avatar Oct 28 '22 01:10 Nyr97