TrinityCore doesn't recognize MariaDB as valid server version on windows

[CraftedRO]

Description

TrinityCore does recognize MariaDB-10.4.10 as MySQL server ver: 5.5.5 witch is wrong and lead server to auto-shutdown .

TrinityCore rev. 18121ae24a8d 2022-09-14 12:28:48 +0200 (3.3.5 branch) (Win64, RelWithDebInfo, Static) (authserver)
<Ctrl-C> to stop.

 ______                       __
/\__  _\       __          __/\ \__
\/_/\ \/ _ __ /\_\    ___ /\_\ \, _\  __  __
   \ \ \/\`'__\/\ \ /' _ `\/\ \ \ \/ /\ \/\ \
    \ \ \ \ \/ \ \ \/\ \/\ \ \ \ \ \_\ \ \_\ \
     \ \_\ \_\  \ \_\ \_\ \_\ \_\ \__\\/`____ \
      \/_/\/_/   \/_/\/_/\/_/\/_/\/__/ `/___/> \
                                 C O R E  /\___/
http://TrinityCore.org                    \/__/

Using configuration file D:/Games/Craftedwow/authserver.conf.
Using SSL version: OpenSSL 1.1.1q  5 Jul 2022 (library: OpenSSL 1.1.1q  5 Jul 2022)
Using Boost version: 1.80.0
Automatic database updates are disabled for all databases!
Opening DatabasePool 'auth'. Asynchronous connections: 1, synchronous connections: 1.
MySQL client library: 8.0.28
MySQL server ver: 5.5.5-10.4.10-MariaDB 
Connected to MySQL database at 127.0.0.1
TrinityCore does not support MySQL versions below 5.7 (found id 50505, need id >= 50700), please update your MySQL server

DatabasePool Login NOT opened. There were errors opening the MySQL connections. Check your SQLDriverLogFile for specific errors. Read wiki at http://www.trinitycore.info/display/tc/TrinityCore+Home

You can only start this by reverting server requirements in databaseworkerpool.cpp back to 5.1

Expected behaviour

TrinityCore shoud recognize MariaDB 10.2+ as valid server version start normally.

Steps to reproduce the problem

On windows try to install then open the server on any xampp for example with mariadb 10.2+ Probably is same on debian 10 witch include mariadb 10.3

Branch

3.3.5

TC rev. hash/commit

18121ae24a8d

Operating system

Windows 10 x64

Custom changes

None

[Aokromes]

fresh installed debian 11

aokromes@debian:~/bin/bin$ ./authserver 
TrinityCore rev. a50ce8755b43 2021-09-16 04:43:06 +0300 (3.3.5 branch) (Unix, RelWithDebInfo, Static) (authserver)
<Ctrl-C> to stop.

 ______                       __
/\__  _\       __          __/\ \__
\/_/\ \/ _ __ /\_\    ___ /\_\ \, _\  __  __
   \ \ \/\`'__\/\ \ /' _ `\/\ \ \ \/ /\ \/\ \
    \ \ \ \ \/ \ \ \/\ \/\ \ \ \ \ \_\ \ \_\ \
     \ \_\ \_\  \ \_\ \_\ \_\ \_\ \__\\/`____ \
      \/_/\/_/   \/_/\/_/\/_/\/_/\/__/ `/___/> \
                                 C O R E  /\___/
http://TrinityCore.org                    \/__/

Using configuration file /home/aokromes/etc/authserver.conf.
Using SSL version: OpenSSL 1.1.1k  25 Mar 2021 (library: OpenSSL 1.1.1k  25 Mar 2021)
Using Boost version: 1.74.0
Automatic database updates are disabled for all databases!
Opening DatabasePool 'auth'. Asynchronous connections: 1, synchronous connections: 1.
MySQL client library: 10.5.11
MySQL server ver: 10.5.11-MariaDB-1 
Connected to MySQL database at 127.0.0.1
MySQL client library: 10.5.11
MySQL server ver: 10.5.11-MariaDB-1 
Connected to MySQL database at 127.0.0.1
DatabasePool 'auth' opened successfully. 2 total connections running.

[Faq]

But report screen is on windows.

[CraftedRO]

And besides I was talking mainly about MariaDB 10.2 (10.4 tested).

[Aokromes]

works also with mysql Ver 15.1 Distrib 10.3.29-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 of debian 10.

[jackpoz]

Let's reopen it until someone tests Windows

[jackpoz]

@banehammer which MariaDB version ? which TC version ?

[ghost]

@jackpoz Oh I am sorry. I was on the wrong path. :/

[Winfidonarleyan]

my commit azerothcore/azerothcore-wotlk@5c1b129 fixed only MariaDB 10.6 and higher

[CraftedRO]

Then there's need something similar to your's.

[Winfidonarleyan]

Just look this https://github.com/TrinityCore/TrinityCore/commit/277b401df45879fa33345878be8864e3ba5aa8c3 Can make pr and add support other versions

[qyh214]

confirm in windows. Test in: https://github.com/TrinityCore/TrinityCore/commit/887605d945fd2330865e84fd066a84e6f4570149 Windows 10 x64 server:MariaDB 10.4.18

2021-10-12_22:33:31 INFO  [sql.sql] MySQL client library: 5.7.35
2021-10-12_22:33:31 INFO  [sql.sql] MySQL server ver: 5.5.5-10.4.18-MariaDB 
2021-10-12_22:33:31 INFO  [sql.sql] Connected to MySQL database at 127.0.0.1
2021-10-12_22:33:31 ERROR [sql.driver] TrinityCore does not support MySQL versions below 5.7 (found id 50505, need id >= 50700), please update your MySQL server

[CraftedRO]

Apparently this issue is beyond my knowledge.

[CraftedRO]

https://github.com/TrinityCore/TrinityCore/discussions/27826