aspnetcore-angular-universal icon indicating copy to clipboard operation
aspnetcore-angular-universal copied to clipboard

Question about Swagger support

Open GetTaxSolutions opened this issue 7 years ago • 4 comments

Hello,

In this project is using package Swackbucle.AspNetCore 1.0.0 for swagger implementation. But when I open the http://swagger.io site and download server side example for .Net core the packages which are included are Swashbuckle.SwaggerGen (>= 6.0.0-T2016120822) and Swashbuckle.SwaggerUi (>= 6.0.0-T2016120822) - (NOT Swackbucle.AspNetCore 1.0.0) In packages description looks like that them support .Net Core and .Net standard v1.6. What is the different between current package in use and these new packages v.6.0.0. What of them is better to be used in the future? I suppose that swagger team with continue with 6.0.0 support. What do you think about this?

Thank you

GetTaxSolutions avatar Oct 18 '17 12:10 GetTaxSolutions

It hasn't been updated in quite a while here but of course it'd be best for us to use the latest and greatest swagger! If you're able to get it working with the latest and have the time to get a pull request in to update it here it'd be very helpful for anyone using the repo! Let me know 👍@gettaxsolutions

MarkPieszak avatar Oct 18 '17 21:10 MarkPieszak

Ok, We already tested with the last packages and looks good. We have created branch locally and can push it if you give us access to do it.

GetTaxSolutions avatar Oct 19 '17 06:10 GetTaxSolutions

@GetTaxSolutions do a fork and open a PR and we will review

isaacrlevin avatar Nov 13 '17 02:11 isaacrlevin

Seeing PR https://github.com/MarkPieszak/aspnetcore-angular2-universal/pull/492 I don't think it is correct to use:

<PackageReference Include="Swashbuckle.SwaggerGen" Version="6.0.0-beta902" />
<PackageReference Include="Swashbuckle.SwaggerUi" Version="6.0.0-beta902" />

Instead of:

<PackageReference Include="Swashbuckle.AspNetCore" Version="1.0.0" />

See README.md on top of this Github repository - domaindrivendev/Swashbuckle. The owner redirects us to his other Github repository - domaindrivendev/Swashbuckle.AspNetCore

Also look at the most recent contributions to both repositories: Swashbuckle = 15th September 2017 Swashbuckle.AspNetCore = Today

Swashbuckle.AspNetCore is definitely the way to go.

MaxMommersteeg avatar Feb 19 '18 20:02 MaxMommersteeg