MovingWorld icon indicating copy to clipboard operation
MovingWorld copied to clipboard

New movingworld entity cannot be created on deletion of dimension folder.

Open PfisterFactor opened this issue 8 years ago • 4 comments

  1. Create a new MovingWorld
  2. Exit to menu
  3. Delete dimension folder that was associated with MovingWorld
  4. Go back into game
  5. Attempt creating a new MovingWorld

Expected: A new MovingWorld being created Actual: NullPointerException in cloneToSubworld

I'll try to fix this and submit a pull request later. Was just a little issue I noted when testing.

PfisterFactor avatar Mar 12 '17 19:03 PfisterFactor

Should note that this is fixed upon restarting Minecraft.

PfisterFactor avatar Mar 12 '17 19:03 PfisterFactor

On further testing this bug can be recreated by simply joining a world, leaving it, then rejoining and attempting to create a ship.

PfisterFactor avatar Mar 13 '17 17:03 PfisterFactor

Fairly sure this is related to dimension registration and initialization. I'll take a look.

On Mar 13, 2017 10:04 AM, "Eric Pfister" [email protected] wrote:

On further testing this bug can be recreated by simply joining a world, leaving it, then rejoining and attempting to create a ship.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/elytra/MovingWorld/issues/37#issuecomment-286173480, or mute the thread https://github.com/notifications/unsubscribe-auth/ABusJHzhEVCSXX5oeQceHnzAJZP7eoM8ks5rlXcSgaJpZM4MapFM .

darkevilmac avatar Mar 13 '17 20:03 darkevilmac

Just tested, It's related to world registration like I thought, registered dimensions aren't being cleared. Most of that code is temporary however and will be replaced with some more clean and sane code that will actually work on dedicated servers as well. I'll keep this open for now but I'm most likely going to leave things as is and focus on testing worlds as they are right now.

darkevilmac avatar Mar 13 '17 22:03 darkevilmac