tribler icon indicating copy to clipboard operation
tribler copied to clipboard

Published 20 hours ago • verified publisher icon Tribler

link detection fix

Open Dmole opened this issue 3 years ago • 10 comments

link detection fix

Dmole avatar Jan 10 '22 16:01 Dmole

Can one of the admins verify this patch?

tribler-ci avatar Jan 10 '22 16:01 tribler-ci

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 10 '22 16:01 sonarqubecloud[bot]

ok to test

xoriole avatar Jan 10 '22 17:01 xoriole

I've converted this PR to "draft" as it is still in WIP state.

drew2a avatar Mar 04 '22 09:03 drew2a

I've converted this PR to "draft" as it is still in WIP state.

Let me know what needs to change to get it merged.

Dmole avatar Mar 04 '22 10:03 Dmole

Let me know what needs to change to get it merged.

As far as I know -- it is necessary to address all @xoriole requests and re-request his review 👍 image

drew2a avatar Mar 04 '22 10:03 drew2a

@Dmole please, update your branch to the latest main. The current test failures are caused by changes from https://github.com/Tribler/tribler/pull/6799.

drew2a avatar Mar 04 '22 12:03 drew2a

Give me 1 hour and I'll fix the test run (no action needed from your side).

drew2a avatar Mar 04 '22 12:03 drew2a

Ok, I've fixed test runs. Now tests from the latest main should work fine.

drew2a avatar Mar 04 '22 13:03 drew2a

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Mar 28 '22 21:03 sonarqubecloud[bot]

@Dmole I have tested the PR on both Linux and macOS, and it works. Please rebase the PR to get it merged.

xoriole avatar Nov 24 '22 14:11 xoriole