tribler installer does not remember installation directory

[kotenok2000]

I have installed Tribler_7.10.0-RC2 at E:\Program Files\Tribler when i installed Tribler_7.10.0 it tried to install to C:\Program Files\Tribler

Please, fill all relevant items:

• [x] I have read CONTRIBUTING.rst

• [x] I have tried with the latest pre-release version and I still can reproduce the issue.

Tribler version/branch+revision:

Operating system and version:

Microsoft Windows [Version 10.0.19043.1083]

Steps to reproduce the behavior:

Expected behavior:

Actual behavior:

Relevant log file output:

[kotenok2000]

Still happens when installing V7.11.0-RC2 Microsoft Windows [Version 10.0.22000.376]

[qstokkink]

By manually setting Software\Tribler in HKCU I managed to get our current (7.13) installer to recognize the install dir.

This tells me that our current approach to recover the value works:

https://github.com/Tribler/tribler/blob/cbd15ef5a20e6d36b1c6353c34ac84dded9c8f1d/build/win/resources/tribler.nsi#L34

However, we should still actively set/write this registry value upon successfully installing Tribler. It seems that the solution of #6244 came very close to this.

I made a test installer to confirm the following fix works:

WriteRegStr HKCU "Software\Tribler" "" "C:\PreviousTriblerDir"

Of course, "C:\PreviousTriblerDir" would be replaced with "$INSTDIR" in our actual installer.