dispersy icon indicating copy to clipboard operation
dispersy copied to clipboard

Infinite growing dictionary in Dispersy statistics

Open devos50 opened this issue 6 years ago • 2 comments

The dictionaries stored in the Dispersy statistics (MessageStatistics) are always growing and never pruned. When running Tribler for extended periods of time, this leads to significant memory usage. See for instance https://github.com/Tribler/dispersy/blob/devel/statistics.py#L82. It seems that we're storing full details about all introduction requests sent and received. The same goes for walk_failure_dict.

To fix this, we can either periodically prune the dictionaries or disable the Dispersy statistics. @qstokkink do you have any comments on this? I think it's important enough to fix this for Tribler 7.1 👍

devos50 avatar May 31 '18 08:05 devos50

Dispersy is end of life, ~~therefore I will close this issue.~~ so we can simply remove/disable these statistics imo.

qstokkink avatar May 31 '18 09:05 qstokkink

Great!

devos50 avatar May 31 '18 09:05 devos50