UrlChecker
UrlChecker copied to clipboard
Refactor Utils class for Better Readability
Refactored the Utils class to enhance code readability by separating functionalities into two distinct classes:
- Created HttpUtils class for HTTP-related operations.
- Introduced LocaleUtils class for locale-related operations.
- Cleaned up code for improved readability and maintainability.
I'm currently bust with some other projects so I'm afraid it will take time (probably a couple or more weeks) until I can properly review this pr.
Although I'm really interested on it, since "Utils" are one of my favorite things so any suggestion and improvement is really welcomed :D
Expect lots of discussions! (But please feel free to discuss back. I'll provide reasons for why I do things a specific way, but I'm open to be proved wrong!)
Hello,
Thank you for responding back.
Can you please do it in the next two days as it is part of a graded assignment that needs to be implemented before the 28th. So it is my humble request to accept the pr as soon as possible.
If PR will be accepted then i get the grade in the subject else i loose marks. I am open to discuss any changes needs to accept this PR. Please reply her if required.
Thank you for understanding.
On Tue, 26 Mar, 2024, 11:59 TrianguloY, @.***> wrote:
I'm currently bust with some other projects so I'm afraid it will take time (probably a couple or more weeks) until I can properly review this pr.
Although I'm really interested on it, since "Utils" are one of my favorite things so any suggestion and improvement is really welcomed :D
Expect lots of discussions! (But please feel free to discuss back. I'll provide reasons for why I do things a specific way, but I'm open to be proved wrong!)
— Reply to this email directly, view it on GitHub https://github.com/TrianguloY/UrlChecker/pull/338#issuecomment-2020669074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRBMWGZN67HOFV6USXLWYTY2F5NNAVCNFSM6AAAAABFJAPPGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRQGY3DSMBXGQ . You are receiving this because you authored the thread.Message ID: @.***>
I'm sorry but I can't fulfill that. The pr is long enough to require a thorough review, and as I said there are currently issues that require my attention (and I'm already spending some of my time to reply to this).
I'm deeply sorry, but I cannot merge this on such sort notice.
Next time (you or anyone reading this) I recommend to contact with a maintainer first before starting any work (create an issue or a discussion), we can really help and provide indications about the scope of the task if needed. I also recommend to do a smaller change (around 100 lines or 5 files for example).
Again, I'm sorry. I'm glad you choose this repository for your assignment, and I apologize for not being able to merge this sooner, but the circumstances don't allow it.
If you decide to close the pr, I'll understand. But if you want to keep it, I'll review and discuss it in a couple weeks as explained.
Best regards.
This PR builds correctly, here is the generated apk. This unsigned version can be installed alongside the original app and should only be used for testing the changes, not for daily usage.
Download testing apk |
---|
You must be logged in for the link to work. The link will expire at 2024-06-08T12:12:42Z.
This is an automatic comment created by a Github Action