Error Checking in Package Macros

[kevindugan]

In certain packages of VERA, the following logic is followed:

TRIBITS_PACKAGE_DECL(PackageName)
 
TRIBITS_PROCESS_SUBPACKAGES()
 
[other Tribits macro]
 
TRIBITS_PACKAGE_DEF()

where [other Tribits macro] can be TRIBITS_ADD_TEST_DIRECTORIES or TRIBITS_ADD_EXECUTABLE for example.

I think that the error checking should be based on the variable ${PACKAGE_NAME}_TRIBITS_PACKAGE_DECL_CALLED instead of ${PACKAGE_NAME}_TRIBITS_PACKAGE_CALLED in these cases to allow for the forward declaration of a package.