MyFinances icon indicating copy to clipboard operation
MyFinances copied to clipboard

Remove currency conversion

Open vatsaaaal opened this issue 1 year ago • 4 comments

Description

This pull request removes the currency conversion feature from the project, which includes:

  • Removing all frontend, backend, and API files related to the currency converter.
  • Removing the test files associated with the currency converter.
  • Removing the 'forex-python' dependency from the 'pyproject.toml' file.
  • Running 'poetry update' to update dependencies.

Motivation

The currency conversion feature was deemed to have no significant purpose and caused more hassle than benefit, as per issue #460 .

Dependencies

No new dependencies are required for this change.

Checklist

  • [x] Ran the Black Formatter and djLint-er on any new code (checks will fail without)
  • [x] Made any changes or additions to the documentation where required
  • [x] Changes generate no new warnings/errors
  • [x] New and existing unit tests pass locally with my changes

What type of PR is this?

  • 🐛 Bug Fix
  • ♻️ Code Refactor

Added/updated tests?

  • 🙅 no, because they aren't needed

Related PRs, Issues etc

  • Closes #460

vatsaaaal avatar Aug 01 '24 22:08 vatsaaaal

Hey @vatsaaaal,

Welcome to the project, and thanks for the contribution! I'll review (+ hopefully merge) the PR tomorrow afternoon, I've got a few things planned for the morning

TreyWW avatar Aug 01 '24 22:08 TreyWW

Thank you. Sounds good @TreyWW !

vatsaaaal avatar Aug 01 '24 22:08 vatsaaaal

Apologies for the delay, I went away and didn't have a chance to review this before. I'm back now, just going to finish my PR then I'll get back to this. Hopefully within the next 2 days. Thanks again for the contribution and patience

TreyWW avatar Aug 05 '24 11:08 TreyWW

Okay, no worries.

vatsaaaal avatar Aug 08 '24 22:08 vatsaaaal

Thanks again for the PR, really appreciate it! 💜

TreyWW avatar Aug 22 '24 20:08 TreyWW