MyFinances icon indicating copy to clipboard operation
MyFinances copied to clipboard

Client specific invoice default logo

Open hussein-mamane opened this issue 1 year ago • 3 comments

Description

If User does not add a logo for an invoice, this feature is a fallback that will add add a default invoice logo configured for the specific client, makes it faster to recognize a client's invoices.

Changes

  • added a field in the client_defaults.html form
  • changed client_defaults form to be hx-post from hx-put
  • added an Image field in the ClientDefaults model for the invoice logo
  • changed the change_client_defaults_endpoint and change_client_defaults methods to support POST
  • changed the invoice creation method to use the fallback logo if needed

Warn

Every Time a user change clients defaults he must also change or re-upload the logo to avoid nullifying it.

Related PRs, Issues etc

  • Related Issue #443
  • Closes #443

hussein-mamane avatar Jul 22 '24 16:07 hussein-mamane

/remind 18h Work on this PR.

  • fix conflicts
  • fix NoneType bug when Defaults doesn't exist (should auto fix when fixing conflicts tho)
  • merge

TreyWW avatar Jul 22 '24 19:07 TreyWW

@TreyWW, ok! I will remind you on Tuesday, July 7, 24 at 13:05 PM!

If you would like to ignore this message, please reply with the reference DELREPLY-I2WVNAG2 (you may delete this reply afterwards)

:wave: @TreyWW, Work on this PR. - fix conflicts - fix NoneType bug when Defaults doesn't exist (should auto fix when fixing conflicts tho) - merge

If you would like to ignore this message, please reply with the reference DELREPLY-U17BP2F2 (you may delete this reply afterwards)