MyFinances icon indicating copy to clipboard operation
MyFinances copied to clipboard

Published 20 hours ago • verified publisher icon TreyWW

bug: No message for new user about checking and verifying email

Open introkun opened this issue 10 months ago • 13 comments

What version of MyFinances are you currently using?

v0.2.1

What device type are you currently facing the issue on?

Desktop

Describe the bug

Steps:

  • create a new user with manual details (non-github/google) Actual result:
  • login screen expecting user's email
  • user is not able to log in (no error message in #245)

Expected result:

  • user-friendly message to check the inbox and activate account by verifying email

introkun avatar Mar 31 '24 14:03 introkun

Related to #245

introkun avatar Mar 31 '24 14:03 introkun

I would like to work on this issue, thanks!

ssheth75 avatar Apr 01 '24 01:04 ssheth75

Same, we are working together so wanted to know if we both could be assigned?

kryptokun avatar Apr 01 '24 01:04 kryptokun

Sure thing! Sorry I completely missed your messages.

TreyWW avatar Apr 01 '24 18:04 TreyWW

I'm having trouble finding the code where the message for new user function is. Could I get some help locating it? I know that the functionality will occur in the login_initial.html

kryptokun avatar Apr 02 '24 17:04 kryptokun

It's probably in backend/views/core/auth/login.py

TreyWW avatar Apr 02 '24 19:04 TreyWW

Any progress @kryptokun?

TreyWW avatar Apr 20 '24 15:04 TreyWW

Sorry was packed with a lot of school work. Will get on it this weekend

kryptokun avatar Apr 20 '24 21:04 kryptokun

Amazing, no problem, just making sure you aren't stuck :)

TreyWW avatar Apr 20 '24 21:04 TreyWW

Would you like to be unassigned from this issue @kryptokun?

TreyWW avatar May 01 '24 15:05 TreyWW

@TreyWW This issue is outdated since PR #270 have resolved that problem. Unfortunately latest PR #362 have broke that functionality since it wasn't caught in tests and I just discovered this while testing on server.

I will revert that change and this issue can be closed.

Edit: Now I noticed that your latest commit have fixed that issue from #362 so I will just send update for type: ignore

One thing is that to have this functionality working we need to provide some testing random API key in .env, for example:

SENDGRID_API_KEY=asd87aFDASDFE*f7fsd86asHDZSDJHAs87212b121

I can update .env.sample with it if you like. Let me know, then I will send both changes in one PR.

Domejko avatar May 05 '24 12:05 Domejko

Hmm since we've moved to SES for emails we've not continued support for Sendgrid. Maybe I should do a revamp for emails and allow for either to be used?

TreyWW avatar May 05 '24 13:05 TreyWW

I think that since it's open source project it will be good to have a choice.

Domejko avatar May 05 '24 18:05 Domejko