tres icon indicating copy to clipboard operation
tres copied to clipboard
verified publisher icon Tresjs

refactor(loop): remove unescessary call to getElapsedTime

Open AlaricBaraou opened this issue 10 months ago • 1 comments

The call is not causing any bug since it is called immediatly after getDelta but it is doing a duplicate job with getDelta() that is already updating the .elapsedTime property.

https://github.com/mrdoob/three.js/blob/master/src/core/Clock.js#L58

AlaricBaraou avatar Feb 10 '25 12:02 AlaricBaraou

Deploy Preview for tresjs-docs failed. Why did it fail? →

Name Link
Latest commit 49fbc689348a2e2db71ba31127f8512ee92359ef
Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/67a9f0efffebd20008986a7f

netlify[bot] avatar Feb 10 '25 12:02 netlify[bot]

@AlaricBaraou could you by chance rebase your branch on the latest status of main? :)

Thanks!

colinscz avatar Jun 17 '25 15:06 colinscz

Deploy Preview for tresjs-docs ready!

Name Link
Latest commit a544a8f973e223f05f7c496c2389013211ed8966
Latest deploy log https://app.netlify.com/projects/tresjs-docs/deploys/68518d74c4437500081e5d69
Deploy Preview https://deploy-preview-928--tresjs-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jun 17 '25 15:06 netlify[bot]

Thanks @colinscz, it should be good now 👍

AlaricBaraou avatar Jun 17 '25 15:06 AlaricBaraou

Thanks @AlaricBaraou I just link the documentation entry here as well. https://threejs.org/docs/#api/en/core/Clock.getDelta

@alvarosabu the PR is all yours :)

colinscz avatar Jun 18 '25 15:06 colinscz

@AlaricBaraou Thank you for pointing to this. 🙌 I applied your suggestion to the changes we made concerning v5 here.

Tinoooo avatar Jun 22 '25 09:06 Tinoooo

I'm closing this PR as the changes are reflected with the release of v5 now.

Tinoooo avatar Sep 24 '25 10:09 Tinoooo