tres icon indicating copy to clipboard operation
tres copied to clipboard

Component: The setting parameter disableRender of TresCanvas is ineffective when renderMode is set to always.

Open hawk86104 opened this issue 1 year ago • 2 comments

Describe the bug

As mentioned in the title, in version v4.1.0

Reproduction

https://stackblitz.com/edit/tresjs-minimal-reproduction-7tdaba?file=src%2FApp.vue

Steps to reproduce

No response

System Info

No response

Used Package Manager

npm

Code of Conduct

hawk86104 avatar Jul 11 '24 02:07 hawk86104

v4.10 lib file:src/utils/index.ts setPrimitiveObject

// NOTE: copy added/attached Vue children // We need to insert objects into newObject later. // In the meantime, remove(primitive) will alter // the array, so make a copy.

I believe there is an issue with this. In the following code, meshOB cannot be operated on.

<primitive :object="gridHelp" />
gridHelp.parent 
gridHelp.visible = false

hawk86104 avatar Jul 11 '24 04:07 hawk86104

Actually that prop disableRender should be deprecated

alvarosabu avatar Jul 11 '24 09:07 alvarosabu

@alvarosabu I can work on this if no one already working on this one

Neosoulink avatar Aug 24 '24 15:08 Neosoulink

Deprecating the prop is not possible anymore as it already has no effect. I removed it in #838.

Tinoooo avatar Sep 22 '24 20:09 Tinoooo