leches icon indicating copy to clipboard operation
leches copied to clipboard

style: Implement Dark Mode

Open Readpato opened this issue 1 year ago • 5 comments

Description

Summary

Changes

What kind of change does this PR introduce? (check at least one by adding an "x" between the brackets)

  • [ ] Build-related changes
  • [ ] Bugfix
  • [X] Code style update
  • [X] Feature
  • [ ] Refactor
  • [X] Style:
    • Implement dark mode
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [X] No

Screenshots and videos

  • If applicable, add screenshots or a video to help explain your problem.

https://github.com/Tresjs/leches/assets/87768087/d9b68b2c-660a-4cea-a2cd-faa29c60581f

The PR fulfils these requirements:

If adding a new feature, the PR's description includes:

  • [x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Dark mode is a good implementation to improve the UX for everyone that utilizes the package.

Other information:

Let me know any changes that need to be done if needed!

Readpato avatar Dec 17 '23 11:12 Readpato

Deploy Preview for tresleches ready!

Name Link
Latest commit a6198c54e089f97189251711b419103efcfe4e5d
Latest deploy log https://app.netlify.com/sites/tresleches/deploys/65801f6fce7048000877fe7c
Deploy Preview https://deploy-preview-95--tresleches.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 17 '23 11:12 netlify[bot]

Hey @Readpato thanks for taking the time to bring everything from the fork to the repo and for the granular and detailed git commit history, 👏🏻

Small thing, (I missed it when asking the first time) when creating the branch add the number of the issue like feat/75-dark-mode

I'm gonna check the PR today, let you know soon

alvarosabu avatar Dec 18 '23 09:12 alvarosabu

Screenshot 2023-12-18 at 11 06 38

Folders look different now, they had a subtle gray background and no border before.

alvarosabu avatar Dec 18 '23 10:12 alvarosabu

@Readpato I just committed a small change regarding the styles of the icon for toggling the dark mode.

Before it had the same visual hierarchy as the cake icon (which symbolizes the mini branding of the component and will serve as an expand/collapse button in the near future) so since the functionality is also different I changed for a more subtle icon (also the right part is gonna serve as a toolbar of actions, where we will add a search icon soon)

Screenshot 2023-12-18 at 11 29 25 Screenshot 2023-12-18 at 11 29 38

Let me know what do you think

alvarosabu avatar Dec 18 '23 10:12 alvarosabu

Hey @alvarosabu! Thank you for your review. Means a lot <3 I'm totally on board with utilizing an icon instead of an emoji for toggling the dark mode. Also, I was wondering to properly commit to a project, sometimes I notice that different files are being modified automatically like stats.html, auto-imports.d.ts, etc. Should I commit those as well whenever I work on the project?

Readpato avatar Dec 21 '23 18:12 Readpato