Kaleb Luedtke

Results 527 comments of Kaleb Luedtke

> Though the tests were fixed, I just realized AdvancedInstaller is an installer authoring tool that supports exe, msi, msix, appv, etc. We may need to reevaluate how we approach...

I would add onto this, though, that msi and msix already have their own installer types (and appv isn't a supported type anyways). It wouldn't be insurmountable to document that...

In that case, would changing this to advInstallerExe suffice, which would allow for advInstallerMsi as well?

> In that case, would changing this to advInstallerExe suffice, which would allow for advInstallerMsi as well? @yao-msft Thoughts on this approach?

You may want to take a look at adding [Tab Completion](https://github.com/microsoft/winget-cli/blob/master/doc/Completion.md) to your profile. It will allow you to enter a partial name / id and then you can use...

It doesn't seem like the correct log file was provided. Can you retry and provide the log when using the flag `--verbose-logs` ?

> Just my 2 cents before we get too far into implementation. I'm not sure if this is of high importance since we already validated the zip hash before extracting....

> Going through the help message (-?), I see that --include-unknown is missing Interesting. I see it in the screenshot you shared as `-u,--unknown,--include-unknown`, right below `-r,--recurse,--all`. > Also for...