react-carousel icon indicating copy to clipboard operation
react-carousel copied to clipboard

we don't want to call `setState` after unmount.

Open unworthyEnzyme opened this issue 2 years ago • 0 comments

Description

We should cleanup all the async tasks after react unmounts the component otherwise this can potentially cause a memory leak.

Additional context

I am not sure if this is a right solution in the case of react code. We could use a cancel token with useRef but this solution seemed more framework agnostic.


What is the purpose of this pull request?

  • [X] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [ ] Ideally, include relevant tests that fail without this PR but pass with it. diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE.md b/.github/workflows/PULL_REQUEST_TEMPLATE.md

unworthyEnzyme avatar Sep 22 '22 18:09 unworthyEnzyme