react-carousel icon indicating copy to clipboard operation
react-carousel copied to clipboard

Remove reference to window to fix ssr error

Open davidpdd opened this issue 2 years ago • 1 comments

Description

Removes window reference in scrolling-carousel that breaks server side rendering during build when the component is used in Gatsby.

Additional context


What is the purpose of this pull request?

  • [x] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [ ] Ideally, include relevant tests that fail without this PR but pass with it. diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE.md b/.github/workflows/PULL_REQUEST_TEMPLATE.md

davidpdd avatar Apr 22 '22 18:04 davidpdd

I'm interested in this feature. Is there any discussion on merging fixes like this to help with SSR?

Nicholas-Sliter avatar Dec 25 '22 17:12 Nicholas-Sliter