kink icon indicating copy to clipboard operation
kink copied to clipboard

Add missing name input on the delete command

Open gadiener opened this issue 2 years ago • 5 comments

Thanks for the effort spent on this project!

Currently, the delete command doesn't support deleting a single cluster without selecting it with the interactive shell. This pull request adds the --name option to allow this behavior.

There is also the new --silent flag to skip the last interactive confirmation to make running the CLI in the CI/CD easier.

I am looking forward to hearing your feedback and comments.

gadiener avatar Jul 07 '22 10:07 gadiener

Looks good!

brenwell avatar Jul 07 '22 10:07 brenwell

@developer-guy, sorry to ping you directly here. Perhaps you can help with a review?

gadiener avatar Jul 11 '22 09:07 gadiener

Great, thanks for your interest 🤗I'll take a look at it ASAP

developer-guy avatar Jul 11 '22 09:07 developer-guy

~~I see the CI failed on the golangci stage. I tried running it locally, and it seems to pass without any issue. Do you have any tips on that?~~

gadiener avatar Jul 11 '22 12:07 gadiener

Morning @developer-guy, I'm looking forward to get your feedback here

gadiener avatar Jul 26 '22 09:07 gadiener