TrenchBroom icon indicating copy to clipboard operation
TrenchBroom copied to clipboard

Pass nodes to visitor by reference

Open kduske opened this issue 1 year ago • 0 comments

Currently, node visitors take the node subclasses by pointer:

kdl::overload(
    [](const WorldNode* worldNode) {},
    [](const LayerNode* layerNode) {},
    [](const GroupNode* groupNode) {},
    [](const EntityNode* entityNode) {},
    [](const BrushNode* brushNode) {},
    [](const PatchNode* patchNode) {})

But they should take them by reference because they can never be null.

kduske avatar Dec 29 '23 14:12 kduske