nestjs-graphql-dataloader icon indicating copy to clipboard operation
nestjs-graphql-dataloader copied to clipboard

Missing Types in Published NPM Module

Open icereval opened this issue 5 years ago • 4 comments

FYI, the published npm module as of v0.1.28 does not include the generated type definition file in dist/index.d.ts.

Thanks for taking the time to publish this nifty utility!

icereval avatar Jul 02 '20 17:07 icereval

Thanks for reporting this, I will ensure this is resolved in the next few days.

TreeMan360 avatar Aug 18 '20 06:08 TreeMan360

Bump to get this in!

I was going to submit a PR as I assumed it was a build issue but the types are definitely generated fine in the dist folder, just weren't pushed with the package.

Thanks loads for this lib though. I've done much more bare-bones GraphQL projects previously and used dataloader directly, but was a bit nervous about exactly this issue when I saw that NestJS didn't have anything set up for it!

jpwilliams avatar Oct 12 '20 16:10 jpwilliams

@TreeMan360 any chance we can get these types packaged in?

cheers

jared-fraser avatar Dec 13 '20 12:12 jared-fraser

Would be really nice to get the types published. Makes it a lot easier to work with.

holm avatar Feb 08 '21 08:02 holm