premature termination on linux/amd64

Open miso- opened this issue 11 years ago • 1 comments

simulavr terminates prematurely on linux/amd64 with message: "FATAL: file traceval.cpp: line 212: add TraceValue denied: wrong name: 'PC', scope is 'CORE.'". This behavior is caused by if(n.find('.') != (unsigned int)-1) check, in traceval.cpp:210 because string::find() returns size_t which is unsigned long, which happens to be of different (8) size than int (4). I'v created patch https://github.com/miso-/simulavr/commit/7141f505270be47bb5fcca0e0cd90adb4dbae2ed that makes simulavr work on linux/amd64. Please review.

May 09 '14 11:05 miso-

Maybe I'm a bit late, but yes, I had this, too. As I wasn't so keen on hunting this down, I first rebased the traumflug branch onto the latest one from upstream. They already fixed the issue there, but your patch appears to be more complete. So I cherry-picked the commit, just modified the hunk in traceval.cpp aroung line 355 a bit. Another hunk didn't apply because it was done upstream already.

Thank you very much for the contribution. Does it work now for you, too?

Jun 24 '14 23:06 Traumflug