ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Reformat general

Open HotzingTone opened this issue 2 years ago • 14 comments

As explained in the function reformatting open task, each function in the general submodule should be updated to follow the implementation instructions given in the Deep Dive section of the docs. The updates should be applied for both the Ivy API and Backend API. The Deep Dive is the best general resource for learning in detail how functions should be implemented. Many of the functions are not implemented as they should be. You will need to make changes to the current implementations, but you do not need to go through all section of the Deep Dive. Specifically, you should make the following changes, where appropriate:

  1. remove all lambda and direct bindings for backend functions, with each function instead defined using def.
  2. update the function arguments and type hints.
  3. add the correct docstrings
  4. add thorough docstring examples

_

Please keep in mind that the proper way to link an issue to this list is to comment "- [ ] #issue_number" while the issue's title only includes the name of the function you've chosen.

_

  • [x] #23912
  • [x] #1382
  • [x] #2081
  • [ ] #26068
  • [x] #23006
  • [x] #1105
  • [x] #26464
  • [x] #1839
  • [x] #4812
  • [x] #1376
  • [x] #26481
  • [x] #2324
  • [x] #2530
  • [x] #8143
  • [x] #4600
  • [x] #1886
  • [x] #22937
  • [x] #2799
  • [x] #1479
  • [x] #2672
  • [x] #2410
  • [x] #2732
  • [x] #3988
  • [x] #2826
  • [x] #8981
  • [x] #10825
  • [x] #10824
  • [x] #10632
  • [x] #2840
  • [x] #2470
  • [x] #26680
  • [x] #2157
  • [x] #21993
  • [x] #10376
  • [x] #10374
  • [x] #3476
  • [x] #2549
  • [ ] #25856
  • [x] #26875
  • [x] #6179
  • [x] #26188
  • [x] #1972
  • [x] #28361
  • [x] #10630
  • [x] #10631
  • [x] #10624
  • [x] #2908
  • [x] #2813
  • [x] #1638
  • [x] #2395
  • [x] #10723
  • [x] #26308
  • [x] #26498
  • [x] #1637
  • [ ] #26565
  • [x] #9391
  • [x] #10894
  • [x] #4761

The main file paths where these functions are likely to be added are:

  • ivy/functional/ivy/general.py
  • ivy/array/general.py
  • ivy/container/general.py
  • ivy/functional/backends/jax/general.py
  • ivy/functional/backends/mxnet/general.py
  • ivy/functional/backends/numpy/general.py
  • ivy/functional/backends/tensorflow/general.py
  • ivy/functional/backends/torch/general.py
  • ivy/data\_classes/array/general.py

HotzingTone avatar Apr 03 '22 11:04 HotzingTone

  • [ ] #2395

kunwarsaaim avatar Jul 28 '22 23:07 kunwarsaaim

get_all_arrays_in_memory #2404

kshitijgundale avatar Jul 29 '22 08:07 kshitijgundale

get_min_base #2470

Hisham-k avatar Jul 30 '22 19:07 Hisham-k

stable_pow #4360

aplatyps avatar Sep 12 '22 14:09 aplatyps

[ ] #4658

wmfidelis avatar Sep 19 '22 14:09 wmfidelis

[ ] #4660

wmfidelis avatar Sep 19 '22 14:09 wmfidelis

  • [ ] #4812 .

MariaGamal avatar Sep 22 '22 16:09 MariaGamal

  • [ ] #6906

nadidebeyza avatar Nov 11 '22 08:11 nadidebeyza

@ivy-leaves Hello, I marked a sub-task to the following task but it is not tracked by the main task issue, why?

nadidebeyza avatar Nov 12 '22 18:11 nadidebeyza

@ivy-leaves Because it completed before(https://github.com/unifyai/ivy/issues/2082) but it has no completed mark.

nadidebeyza avatar Nov 12 '22 19:11 nadidebeyza

@ivy-leaves I am not sure actually, can you check please?

nadidebeyza avatar Nov 12 '22 19:11 nadidebeyza

#7268

Mukhriddin19980901 avatar Nov 23 '22 04:11 Mukhriddin19980901

Hello, I want to work on the get min denominator issue for my contribution for the machine learning engineering role, can I work on it

Monsurat-Onabajo avatar Feb 09 '23 11:02 Monsurat-Onabajo

Hello, I want to work on the get min denominator issue for my contribution for the machine learning engineering role, can I work on it

YES, YOU CAN! Kindly proceed.

jauvany avatar Feb 18 '23 23:02 jauvany

beandkay avatar Mar 24 '23 07:03 beandkay

Hi can anyone assign me this task I would like to work on this

sushmakoneti avatar Jul 12 '23 18:07 sushmakoneti

  • [x] #22500

musah26 avatar Aug 24 '23 22:08 musah26

  • [ ] #26464

danivpv avatar Oct 06 '23 20:10 danivpv

Hi, I have created this issue #26577 in my git account 2 days ago. the trouble I'm facing is I, can not find the main file paths, where the function is likely to be added as suggested above, from below given paths.

ivy/functional/ivy/general.py ivy/array/general.py ivy/container/general.py ivy/functional/backends/jax/general.py ivy/functional/backends/mxnet/general.py ivy/functional/backends/numpy/general.py ivy/functional/backends/tensorflow/general.py ivy/functional/backends/torch/general.py ivy/data_classes/array/general.py

Hii, I was doing the unify coding challenge for an internship and following the contribution guidelines I had to pick a task that didn't have a comment. Nonetheless I'll check the paths you sent and see where other places need reformatting. I am new to working in open source projects so I am not sure how to proceed if I find a solution, any help would be nice :)

yibeisita avatar Oct 07 '23 07:10 yibeisita

Hi, I have created this issue #26577 in my git account 2 days ago. the trouble I'm facing is I, can not find the main file paths, where the function is likely to be added as suggested above, from below given paths.

ivy/functional/ivy/general.py ivy/array/general.py ivy/container/general.py ivy/functional/backends/jax/general.py ivy/functional/backends/mxnet/general.py ivy/functional/backends/numpy/general.py ivy/functional/backends/tensorflow/general.py ivy/functional/backends/torch/general.py ivy/data_classes/array/general.py

You only need to reformat set_min_base function definition in ivy/array/general.py

yibeisita avatar Oct 07 '23 08:10 yibeisita

#26770

PrateekPal641 avatar Oct 08 '23 09:10 PrateekPal641

  • [ ] #26805

shivakumarmahesh avatar Oct 09 '23 09:10 shivakumarmahesh

  • [ ] #26498

Kacper-W-Kozdon avatar Oct 13 '23 13:10 Kacper-W-Kozdon