ivy
ivy copied to clipboard
Reformat general
As explained in the function reformatting open task, each function in the general submodule should be updated to follow the implementation instructions given in the Deep Dive section of the docs. The updates should be applied for both the Ivy API and Backend API. The Deep Dive is the best general resource for learning in detail how functions should be implemented. Many of the functions are not implemented as they should be. You will need to make changes to the current implementations, but you do not need to go through all section of the Deep Dive. Specifically, you should make the following changes, where appropriate:
- remove all lambda and direct bindings for backend functions, with each function instead defined using def.
- update the function arguments and type hints.
- add the correct docstrings
- add thorough docstring examples
_
Please keep in mind that the proper way to link an issue to this list is to comment "- [ ] #issue_number" while the issue's title only includes the name of the function you've chosen.
_
- [x] #23912
- [x] #1382
- [x] #2081
- [ ] #26068
- [x] #23006
- [x] #1105
- [x] #26464
- [x] #1839
- [x] #4812
- [x] #1376
- [x] #26481
- [x] #2324
- [x] #2530
- [x] #8143
- [x] #4600
- [x] #1886
- [x] #22937
- [x] #2799
- [x] #1479
- [x] #2672
- [x] #2410
- [x] #2732
- [x] #3988
- [x] #2826
- [x] #8981
- [x] #10825
- [x] #10824
- [x] #10632
- [x] #2840
- [x] #2470
- [x] #26680
- [x] #2157
- [x] #21993
- [x] #10376
- [x] #10374
- [x] #3476
- [x] #2549
- [ ] #25856
- [x] #26875
- [x] #6179
- [x] #26188
- [x] #1972
- [x] #28361
- [x] #10630
- [x] #10631
- [x] #10624
- [x] #2908
- [x] #2813
- [x] #1638
- [x] #2395
- [x] #10723
- [x] #26308
- [x] #26498
- [x] #1637
- [ ] #26565
- [x] #9391
- [x] #10894
- [x] #4761
The main file paths where these functions are likely to be added are:
ivy/functional/ivy/general.py
ivy/array/general.py
ivy/container/general.py
ivy/functional/backends/jax/general.py
ivy/functional/backends/mxnet/general.py
ivy/functional/backends/numpy/general.py
ivy/functional/backends/tensorflow/general.py
ivy/functional/backends/torch/general.py
ivy/data\_classes/array/general.py
- [ ] #2395
get_all_arrays_in_memory #2404
get_min_base #2470
stable_pow #4360
[ ] #4658
[ ] #4660
- [ ] #4812 .
- [ ] #6906
@ivy-leaves Hello, I marked a sub-task to the following task but it is not tracked by the main task issue, why?
@ivy-leaves Because it completed before(https://github.com/unifyai/ivy/issues/2082) but it has no completed mark.
@ivy-leaves I am not sure actually, can you check please?
#7268
Hello, I want to work on the get min denominator issue for my contribution for the machine learning engineering role, can I work on it
Hello, I want to work on the get min denominator issue for my contribution for the machine learning engineering role, can I work on it
YES, YOU CAN! Kindly proceed.
- [x] gather #13048
Hi can anyone assign me this task I would like to work on this
- [x] #22500
- [ ] #26464
Hi, I have created this issue #26577 in my git account 2 days ago. the trouble I'm facing is I, can not find the main file paths, where the function is likely to be added as suggested above, from below given paths.
ivy/functional/ivy/general.py ivy/array/general.py ivy/container/general.py ivy/functional/backends/jax/general.py ivy/functional/backends/mxnet/general.py ivy/functional/backends/numpy/general.py ivy/functional/backends/tensorflow/general.py ivy/functional/backends/torch/general.py ivy/data_classes/array/general.py
Hii, I was doing the unify coding challenge for an internship and following the contribution guidelines I had to pick a task that didn't have a comment. Nonetheless I'll check the paths you sent and see where other places need reformatting. I am new to working in open source projects so I am not sure how to proceed if I find a solution, any help would be nice :)
Hi, I have created this issue #26577 in my git account 2 days ago. the trouble I'm facing is I, can not find the main file paths, where the function is likely to be added as suggested above, from below given paths.
ivy/functional/ivy/general.py ivy/array/general.py ivy/container/general.py ivy/functional/backends/jax/general.py ivy/functional/backends/mxnet/general.py ivy/functional/backends/numpy/general.py ivy/functional/backends/tensorflow/general.py ivy/functional/backends/torch/general.py ivy/data_classes/array/general.py
You only need to reformat set_min_base function definition in ivy/array/general.py
#26770
- [ ] #26805
- [ ] #26498