ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Reformat data_type

Open saeedashrraf opened this issue 2 years ago • 7 comments

As explained in the function reformatting open task, each function in the data_type submodule should be updated to follow the implementation instructions given in the Deep Dive section of the docs. The updates should be applied for both the Ivy API and Backend API. The Deep Dive is the best general resource for learning in detail how functions should be implemented. Many of the functions are not implemented as they should be. You will need to make changes to the current implementations, but you do not need to go through all section of the Deep Dive. Specifically, you should make the following changes, where appropriate:

  1. remove all lambda and direct bindings for backend functions, with each function instead defined using def.
  2. update the function arguments and type hints.
  3. add the correct docstrings
  4. add thorough docstring examples

_

Please keep in mind that the proper way to link an issue to this list is to comment "- [ ] #issue_number" while the issue's title only includes the name of the function you've chosen.

_

  • [x] #2020
  • [x] #2168
  • [x] #1910
  • [x] #1688
  • [x] #2029
  • [x] #10281
  • [x] #2041
  • [ ] dtype
  • [x] #2300
  • [ ] #25751
  • [ ] #26494
  • [x] #4430
  • [x] #6459
  • [x] #18105
  • [x] #1900
  • [x] #4277
  • [x] #6148
  • [x] #25278
  • [ ] #25721
  • [x] #2321
  • [x] #23534
  • [x] #23435
  • [x] #1850
  • [x] #2058
  • [ ] convert_dtype

The main file paths where these functions are likely to be added are:

  • ivy/array/data\_type.py
  • ivy/container/data\_type.py
  • ivy/functional/backends/numpy/data\_type.py
  • ivy/functional/ivy/data\_type.py
  • ivy/functional/backends/torch/data\_type.py

saeedashrraf avatar Apr 02 '22 11:04 saeedashrraf

astype #2020

LateefAkinola avatar Jul 27 '22 12:07 LateefAkinola

dtype_to_str #2362

Doregon499 avatar Jul 27 '22 22:07 Doregon499

  • [ ] dtype_to_str #2390

Lancelot03 avatar Jul 28 '22 18:07 Lancelot03

Hey, I'm new here and got the mail to select one task as my first contribution and here I want to pick unset_default_float_dtype as my first task. Can anyone here help me to run the project and start contributing. I've setup everything still not able to run.

Piyush-Khare avatar Nov 21 '22 15:11 Piyush-Khare

result_type has already been handled https://github.com/unifyai/ivy/issues/2041 and is repeated in the TODO list

satakshigarg avatar Feb 18 '23 21:02 satakshigarg

can I work on default_dtype #16122

abdulsamodazeez avatar Jun 01 '23 09:06 abdulsamodazeez

dtype_to_str #22985

kami71539 avatar Sep 03 '23 20:09 kami71539

is_int_dtype #23534

pavan999999999 avatar Sep 13 '23 13:09 pavan999999999

  • [ ] #25751

Kosi-E avatar Oct 03 '23 17:10 Kosi-E