ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Added argwhere function to jax.numpy namespace functions and passed tests. #6049

Open waseef3277 opened this issue 3 years ago • 6 comments

argwhere #6049

waseef3277 avatar Oct 22 '22 19:10 waseef3277

Please can someone review my PR?

waseef3277 avatar Oct 23 '22 14:10 waseef3277

Hello @waseef3277, It seems like you're trying to modify an existing frontend function already, could you revert that and instead add a new function? also could you resolve the conflict?

CatB1t avatar Oct 29 '22 13:10 CatB1t

Hello @waseef3277, It seems like you're trying to modify an existing frontend function already, could you revert that and instead add a new function? also could you resolve the conflict?

It was not there when I created an issue #6049, you can have a look.

waseef3277 avatar Oct 29 '22 13:10 waseef3277

It was not there when I created an issue #6049, you can have a look.

Maybe it was added while you were working on this function, your changes override the function, I'd resetting changes and readding your function to the recent commit from master, this will also resolve the branch conflict, thanks!

CatB1t avatar Oct 31 '22 07:10 CatB1t

It was not there when I created an issue #6049, you can have a look.

Maybe it was added while you were working on this function, your changes override the function, I'd resetting changes and readding your function to the recent commit from master, this will also resolve the branch conflict, thanks!

Okay please do that, I will have to add another function after that?

waseef3277 avatar Oct 31 '22 10:10 waseef3277

It was not there when I created an issue #6049, you can have a look.

Maybe it was added while you were working on this function, your changes override the function, I'd resetting changes and readding your function to the recent commit from master, this will also resolve the branch conflict, thanks!

Okay please do that, I will have to add another function after that?

Sorry for the confusion, I meant to say *I'd suggest to reset the changes, you have to do to it from your side.

CatB1t avatar Nov 04 '22 05:11 CatB1t

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Nov 12 '22 06:11 ivy-seed

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Nov 19 '22 06:11 ivy-seed