ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Published 20 hours ago • verified publisher icon Transpile-AI

Added argsort frontend function to jax.numpy.namespace

Open ukj02 opened this issue 2 years ago • 4 comments

Close #5832

ukj02 avatar Oct 18 '22 22:10 ukj02

I was not sure about my test implementation

ukj02 avatar Oct 18 '22 22:10 ukj02

Maybe taking a look at Ivy tests doc could help: https://lets-unify.ai/ivy/deep_dive/ivy_tests.html

modanesh avatar Oct 19 '22 14:10 modanesh

I noticed that most of the jax.numpy namespace functions tests are failing with the code base. Could you update your PR to be based on this commit: https://github.com/unifyai/ivy/commit/697c634579c5b41552786a280060b6122fcbab91 or a later one so that we could review the test jax.numpy easier and with more confidence?

modanesh avatar Oct 20 '22 06:10 modanesh

Could you please fix the lint tests which failed relevant to your function and also check why test-frontend-jax test is failing? In addition, your commits still have conflicts with the master.

modanesh avatar Oct 23 '22 11:10 modanesh

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Nov 07 '22 09:11 ivy-seed

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Nov 14 '22 06:11 ivy-seed

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Nov 14 '22 07:11 ivy-seed