ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Published 20 hours ago • verified publisher icon Transpile-AI

updated matrix_power function

Open ndurumo254 opened this issue 2 years ago • 12 comments

ndurumo254 avatar Sep 27 '22 06:09 ndurumo254

_ No description provided. _ formatted the task

ndurumo254 avatar Sep 27 '22 06:09 ndurumo254

in case where docker fails, is it advisable to use the venv only?

ndurumo254 avatar Sep 27 '22 06:09 ndurumo254

hello any response to the above pull request?

ndurumo254 avatar Sep 28 '22 09:09 ndurumo254

@ndurumo254 Hello, you need to write the test function also. Check the link for example.

kimbring2 avatar Sep 29 '22 15:09 kimbring2

@ndurumo254 Hello, you need to write the test function also. Check the link for example.

thanks kimbring2 for your response. here is the updated version

ndurumo254 avatar Sep 29 '22 16:09 ndurumo254

Am confused on how i should activate this pull request. i cant see the place to request for review.

ndurumo254 avatar Sep 30 '22 12:09 ndurumo254

@ndurumo254 Thank you for adding the test code. However, you should add code to only one part of the Jax frontend. What was your issue when opening this PR? Was it the jax.lax or jax.numpy?

kimbring2 avatar Oct 02 '22 03:10 kimbring2

@ndurumo254 Thank you for adding the test code. However, you should add code to only one part of the Jax frontend. What was your issue when opening this PR? Was it the jax.lax or jax.numpy?

@kimbring2. thanks for reviewing. my issue was on lax.numpy. I have counter-checked the request and saw I had mixed-up issues. I have however rectified that. looking forward to getting more direction from you.

ndurumo254 avatar Oct 02 '22 06:10 ndurumo254

@ndurumo254 Yes, it seems like the code location is corrected well. However, you need to change the argument name according to document of the actual function.

The purpose of the test function is that the output of the Ivy function is the same as the output of the original function.

kimbring2 avatar Oct 02 '22 06:10 kimbring2

@ndurumo254 Yes, it seems like the code location is corrected well. However, you need to change the argument name according to document of the actual function.

The purpose of the test function is that the output of the Ivy function is the same as the output of the original function.

@kimbring2. changed

ndurumo254 avatar Oct 02 '22 07:10 ndurumo254

@ndurumo254 Yes, it seems like the code location is corrected well. However, you need to change the argument name according to document of the actual function. The purpose of the test function is that the output of the Ivy function is the same as the output of the original function.

@kimbring2. changed @kimbring2 Hello kimbring2, any idea on how i can get out of this error "test-frontend-jax / run-nightly-tests"?

ndurumo254 avatar Oct 02 '22 16:10 ndurumo254

@ndurumo254 Hello,

Actually, you do not need to care about that error. You should run the pytest for the test_jax_numpy_matrix_power function.

How do you run the test now? See the document for that.

kimbring2 avatar Oct 03 '22 02:10 kimbring2

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Nov 07 '22 09:11 ivy-seed

Hi @ndurumo254, are you still working on this PR? It seems to have gone stale, please let me know if you are still working on it and need help.

Auxia avatar Nov 10 '22 19:11 Auxia