ivy
ivy copied to clipboard
Transpile-AI
abs tensorflow
Hi @Aditya-Komaravolu I will do that soon.
Thank you so much! I have one doubt brother. I didn't understand why the frontend test failed, I checked logs, and I didn't find an error related to abs function.
@RashulChutani, as per a small discussion with James today, I have also added the instance of the method in the Tensor class. If you don't mind, by when can I expect a review from your end? So that we can fix things and hopefully merge the PR.
@RashulChutani brother, when can I expect a code review from your end? Please let me know ;)
Hi @Aditya-Komaravolu, It usually takes us 2-3 days, but I will try my best to do it ASAP.
Hi @Aditya-Komaravolu, It usually takes us 2-3 days, but I will try my best to do it ASAP.
Sure brother! Will be definitely waiting for your review😃.
@RashulChutani I have made changes to the test functions and they ran perfectly in local testing. Could you please review them?
@Aditya-Komaravolu Please also check that the CI Tests Pass.
Yep @RashulChutani, the test cases passed for both test functions as stated here:
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.
This PR has been closed because it has been marked as stale for more than 7 days with no activity.