concatenate #4183

[optimusprime009]

Again when I run it the problem jaxlib appears on my windows system.

[Daniel4078]

I have found another pull request(https://github.com/unifyai/ivy/pull/4361) you created for the same SubTask issue. What happened so that you need to create a new pull request?

[Daniel4078]

Another tip: check the ivy.concat() function.

[optimusprime009]

how can i merge new file i am having a difficulty here

[Daniel4078]

can you elaborate a little more about "merge new file"? I do not really get what you mean. Thank you.

[optimusprime009]

i was working on test file so how should I upload it.

[JamieLine]

Hi!

I've just been assigned to this so I haven't had a full look at everything but I can answer your question. Add your test to the appropriate file in your local repository, commit the changes, and push them to your branch. This PR will automaticlly update from there. You'll need to add the test and ensure that it passes with all backends. To run it with all backends, run pytest with --backend=all. If you need help doing that in your specific environment then please let me know you need some help and which code editor you use and I'll help out.

Additionally, you should ensure that your code passes the linting test on this page, you can use flake8 and black locally and if the code passes there it will pass on this page.

Hope this helps!

Any questions or comments please let me know!

[ivy-seed]

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

[optimusprime009]

there is a conflicting issue. The location where I have committed the file is no longer in the repository. What should I do?

[JamieLine]

Hi!

It appears that the file you wish to edit has moved to ivy/functional/frontends/tensorflow/keras/layers.py. Moving your changes there should fix it. Once that is done and an appropriate test has been added, I'll be able to advise further.

Thanks!

[optimusprime009]

def tf.keras.layers.concatenate(inputs, axis=-1, name=None): ^ SyntaxError: invalid syntax

this is shown while running the function

[ukj02]

Hi @optimusprime009 , I have just been assigned to this pull request so I have not seen everything. You are getting a syntax error because you are not following the correct implementation for the frontend function.

Please refer to the Ivy Frontend Guide (specifically the Tensorflow function in your case): https://lets-unify.ai/ivy/deep_dive/ivy_frontends.html

After this write a test for the frontend function you have implemented by following the Ivy Frontend Tests Guide (again read the Tensorflow test implementation in your case):

https://lets-unify.ai/ivy/deep_dive/ivy_frontends_tests.html

I hope this helps!

Let me know if you have any question or comments!

[ivy-seed]

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

[ivy-seed]

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

[optimusprime009]

hello i have committed on the task few 4 days back how come the pull request is closed

[optimusprime009]

#7828