ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Signbit

Open devenderbutani21 opened this issue 3 years ago • 6 comments

close #4362

devenderbutani21 avatar Sep 15 '22 13:09 devenderbutani21

@modanesh Is there an issue in the code?

devenderbutani21 avatar Sep 16 '22 14:09 devenderbutani21

Sorry for the late reply. Have you been able to run tests locally? Asking this because the test_numpy_signbit is failing. For example, at miscellaneous.py:283, I'm getting this: ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all().

modanesh avatar Sep 20 '22 08:09 modanesh

@modanesh I will look into it.

devenderbutani21 avatar Sep 20 '22 15:09 devenderbutani21

@modanesh I have tried to make the change in the frontend so please check it out. Also, I am getting this error while trying to run docker on my pc. "Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or directory."

devenderbutani21 avatar Sep 28 '22 15:09 devenderbutani21

For the docker issue, try to update docker image (and restart it just in case). Regarding the commit, there are 2 lint failures. Check the lint logs to see more details. There are also test-frontend-numpy failures for the signbit(). As I went through them, they're mostly raising the np not being defined errors.

modanesh avatar Sep 28 '22 17:09 modanesh

Hi, There're still failing tests mostly with this error: NameError: name 'np' is not defined which is in the changes of the test_miscellaneous.py file. There're also changes applied to the test_array_api which I'm not sure if necessary or not.

modanesh avatar Oct 07 '22 06:10 modanesh

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Nov 06 '22 14:11 ivy-seed

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Nov 14 '22 06:11 ivy-seed

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Nov 14 '22 07:11 ivy-seed