ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Added broadcast_to to Torch frontend

Open JamieLine opened this issue 2 years ago • 5 comments

Fixes #4111

JamieLine avatar Sep 06 '22 15:09 JamieLine

I've reworked it to use the suggested helpers, and I've checked that the dtype flag does have all valid types.

JamieLine avatar Sep 09 '22 23:09 JamieLine

Apologies, I've clicked the request review button a bit too soon and now there's a merge conflict, I'm quickly checking everything passes and should be done in under 10 minutes unless something drastic went wrong.

JamieLine avatar Sep 09 '22 23:09 JamieLine

The merge conflict has been fixed, but I have had to backport the copy of cumprod from another merge conflict I've requested review for, and the helper has had to be changed to not use dtype_shared but a slightly modified version to meet PyTorch's requirements, namely that PyTorch doesn't support most uint types.

JamieLine avatar Sep 09 '22 23:09 JamieLine

Made the requested changes, the full=False flag is specified because it crashes with an error without it.

JamieLine avatar Sep 12 '22 22:09 JamieLine

Re-opened.

JamieLine avatar Sep 14 '22 19:09 JamieLine

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Nov 07 '22 09:11 ivy-seed

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Nov 14 '22 06:11 ivy-seed

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Nov 14 '22 07:11 ivy-seed