ivy icon indicating copy to clipboard operation
ivy copied to clipboard

`Atan2` and `logical_not` in TensorFlow Frontend and `tanh` in NumPy frontend

Open Lancelot03 opened this issue 2 years ago • 8 comments

Lancelot03 avatar Aug 25 '22 16:08 Lancelot03

#3655 #3656 for Atan2 and logical_not

Lancelot03 avatar Aug 26 '22 13:08 Lancelot03

I also need the issues for the other two functions mentioned in this PR. Once fixes have been made please request another review from me :)

iamjameskeane avatar Aug 26 '22 15:08 iamjameskeane

#3664 tanh

Lancelot03 avatar Aug 26 '22 15:08 Lancelot03

#3666 This issue is for the sinh function for trigonometric_functions.py of NumPy but there is no mention of sinh for trigonometric_function in (#1525) so please check it. And Thanks for helping.

Lancelot03 avatar Aug 26 '22 15:08 Lancelot03

#3666 This issue is for the sinh function for trigonometric_functions.py of NumPy but there is no mention of sinh for trigonometric_function in (#1525) so please check it. And Thanks for helping.

I have checked up on this and sinh has already been implemented in this commit here

I will close your issue and you can remove your implementation from this current commit to save on code duplication!

iamjameskeane avatar Aug 28 '22 15:08 iamjameskeane

@jkeane508 please review it.

Lancelot03 avatar Aug 28 '22 16:08 Lancelot03

@jkeane508 I don't understand why my tests are failing please help me this

Lancelot03 avatar Sep 05 '22 15:09 Lancelot03

@jkeane508 I don't understand why my tests are failing please help me this

Hi @Lancelot03,

You can run these tests locally in the ivy testing suite, you should be able to find out what the error is from there :)

iamjameskeane avatar Sep 06 '22 08:09 iamjameskeane