ivy
ivy copied to clipboard
`Atan2` and `logical_not` in TensorFlow Frontend and `tanh` in NumPy frontend
#3655 #3656 for Atan2 and logical_not
I also need the issues for the other two functions mentioned in this PR. Once fixes have been made please request another review from me :)
#3664 tanh
#3666 This issue is for the sinh function for trigonometric_functions.py of NumPy but there is no mention of sinh for trigonometric_function in (#1525) so please check it. And Thanks for helping.
#3666 This issue is for the sinh function for trigonometric_functions.py of NumPy but there is no mention of sinh for trigonometric_function in (#1525) so please check it. And Thanks for helping.
I have checked up on this and sinh
has already been implemented in this commit here
I will close your issue and you can remove your implementation from this current commit to save on code duplication!
@jkeane508 please review it.
@jkeane508 I don't understand why my tests are failing please help me this
@jkeane508 I don't understand why my tests are failing please help me this
Hi @Lancelot03,
You can run these tests locally in the ivy testing suite, you should be able to find out what the error is from there :)