ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Add Instance Methods to PyTorch Frontend

Open iamjameskeane opened this issue 3 years ago • 10 comments
trafficstars

Add Instance Methods to PyTorch Frontend: _

Please keep in mind that the proper way to link an issue to this list is to comment "- [ ] #issue_number" while the issue's title only includes the name of the function you've chosen.

_

  • [x] #6278
  • [x] #6441
  • [x] #6442
  • [x] #5265
  • [x] #9515
  • [x] #6639
  • [x] #16508
  • [ ] #16671
  • [x] #6478
  • [ ] grad
  • [x] #6405
  • [x] #8882
  • [x] #14411
  • [x] #5804
  • [x] #5818
  • [x] #5819
  • [x] #5820
  • [x] #6011
  • [x] #6817
  • [x] #6560
  • [x] #6816
  • [x] #7134
  • [x] #6815
  • [x] #14645
  • [x] #14646
  • [x] #14981
  • [ ] #14982
  • [x] #14983
  • [x] #14984
  • [x] #14985
  • [x] #14986
  • [ ] sspaddmm
  • [ ] #17485
  • [ ] addmv_
  • [x] #15741
  • [x] #15859
  • [ ] adjoint
  • [ ] #16646
  • [x] #5789
  • [x] #5889
  • [x] #9946
  • [ ] #12930
  • [ ] apply_
  • [x] #6556
  • [x] #7574
  • [x] #9267
  • [x] #7859
  • [x] #5812
  • [x] #6818
  • [x] #5814
  • [x] #6819
  • [x] #17234
  • [ ] atan
  • [x] #6820
  • [x] #6020
  • [x] #6553
  • [x] #7898
  • [x] atan2_
  • [x] #10227
  • [x] #10493
  • [x] #12996
  • [x] #9438
  • [x] #17227
  • [ ] baddbmm_
  • [ ] bernoulli
  • [ ] bernoulli_
  • [ ] bfloat16
  • [x] #13643
  • [x] bitwise_not
  • [ ] #17484
  • [x] #6693
  • [x] #13050
  • [x] #9848
  • [x] #12333
  • [x] #13007
  • [ ] #13092
  • [ ] #13112
  • [ ] bitwise_left_shift_
  • [x] #14845
  • [ ] bitwise_right_shift_
  • [ ] bmm
  • [x] #7841
  • [x] #7842
  • [ ] broadcast_to
  • [ ] cauchy_
  • [x] #7081
  • [x] ceil_
  • [ ] char
  • [ ] cholesky
  • [ ] cholesky_inverse
  • [ ] cholesky_solve
  • [x] #7621
  • [x] #7751
  • [x] #14123
  • [x] #13639
  • [x] #13640
  • [x] clone
  • [ ] contiguous
  • [ ] copy_
  • [ ] conj
  • [ ] conj_physical
  • [ ] conj_physical_
  • [ ] resolve_conj
  • [ ] resolve_neg
  • [x] #15746
  • [ ] copysign_
  • [x] #5739
  • [x] #6068
  • [x] cosh
  • [x] cosh_
  • [ ] corrcoef
  • [x] #13890
  • [ ] cov
  • [x] acosh
  • [x] acosh_
  • [x] #14131
  • [x] #14138
  • [ ] cpu
  • [x] cross
  • [ ] cuda
  • [ ] #12998
  • [ ] #14526
  • [ ] cumprod
  • [ ] #13055_
  • [x] #7530
  • [x] #10231
  • [ ] chalf
  • [ ] cfloat
  • [ ] cdouble
  • [ ] data_ptr
  • [x] #6077
  • [ ] dequantize
  • [x] #14621
  • [ ] dense_dim
  • [x] #6315
  • [x] #15451
  • [x] #17235
  • [ ] diag_embed
  • [ ] diagflat
  • [ ] diagonal
  • [ ] diagonal_scatter
  • [ ] #15720diagonal_
  • [ ] #13167
  • [x] #13164
  • [ ] diff
  • [ ] digamma
  • [ ] digamma_
  • [x] #6404
  • [ ] dist
  • [x] div
  • [x] div_
  • [ ] #15596
  • [ ] divide_
  • [ ] dot
  • [ ] double
  • [x] #10784
  • [ ] eig
  • [ ] element_size
  • [x] #7609
  • [x] #16246
  • [x] #15849
  • [ ] #16257
  • [ ] erf_
  • [ ] erfc
  • [ ] erfc_
  • [ ] erfinv
  • [ ] erfinv_
  • [x] #13158
  • [ ] #14655
  • [x] #15805
  • [ ] expm1_
  • [x] #6302
  • [x] #10325
  • [ ] exponential_
  • [x] #14304
  • [x] #14305
  • [x] fill_
  • [x] #7528
  • [x] #7660
  • [x] #12782
  • [x] #6070
  • [x] #14771
  • [ ] float_power
  • [ ] float_power_
  • [x] #6510
  • [ ] #17015
  • [x] #9512
  • [ ] floor_divide_
  • [x] #15063
  • [x] #14946
  • [ ] frac
  • [ ] frac_
  • [ ] frexp
  • [x] #6318
  • [ ] gcd
  • [ ] gcd_
  • [ ] ge
  • [ ] ge_
  • [x] #16266equal_
  • [ ] geometric_
  • [ ] geqrf
  • [ ] ger
  • [ ] get_device
  • [ ] gt
  • [ ] gt_
  • [x] #15993
  • [x] #16266
  • [x] half
  • [ ] hardshrink
  • [ ] heaviside
  • [ ] histc
  • [ ] histogram
  • [x] #10785
  • [ ] hypot
  • [ ] hypot_
  • [ ] i0
  • [ ] i0_
  • [ ] igamma
  • [ ] igamma_
  • [ ] igammac
  • [ ] igammac_
  • [x] #13950
  • [x] #13951
  • [ ] index_copy_
  • [ ] index_copy
  • [ ] index_fill_
  • [ ] index_fill
  • [ ] index_put_
  • [ ] index_put
  • [ ] index_reduce_
  • [ ] index_reduce
  • [x] #7848
  • [ ] indices
  • [ ] inner
  • [x] #7644
  • [ ] int_repr
  • [x] #7610
  • [ ] isclose
  • [ ] isfinite
  • [ ] #17434
  • [ ] isposinf
  • [ ] isneginf
  • [ ] isnan
  • [ ] is_contiguous
  • [ ] #15732
  • [ ] is_conj
  • [ ] is_floating_point
  • [ ] is_inference
  • [ ] #16634
  • [ ] is_pinned
  • [ ] is_set_to
  • [ ] is_shared
  • [ ] is_signed
  • [ ] is_sparse
  • [ ] istft
  • [ ] isreal
  • [x] item
  • [ ] kthvalue
  • [ ] lcm
  • [ ] lcm_
  • [ ] ldexp
  • [ ] ldexp_
  • [ ] le
  • [ ] le_
  • [ ] less_equal
  • [ ] less_equal_
  • [ ] lerp
  • [ ] lerp_
  • [ ] lgamma
  • [ ] lgamma_
  • [x] #5806
  • [x] log_
  • [x] #14666
  • [x] #14275
  • [ ] #17507
  • [x] #6676
  • [ ] log1p_
  • [x] #12595
  • [ ] log2_
  • [ ] log_normal_
  • [ ] logaddexp
  • [ ] logaddexp2
  • [ ] logcumsumexp
  • [ ] logsumexp
  • [x] #13094
  • [ ] logical_and_
  • [x] #13957
  • [x] logical_not_
  • [x] #13589
  • [ ] logical_or_
  • [ ] logical_xor
  • [ ] logical_xor_
  • [ ] logit
  • [ ] logit_
  • [x] long
  • [ ] lstsq
  • [x] #16422
  • [ ] lt_
  • [ ] less
  • [ ] less_
  • [ ] lu
  • [ ] lu_solve
  • [ ] as_subclass
  • [ ] map_
  • [ ] masked_scatter_
  • [ ] masked_scatter
  • [x] masked_fill_
  • [x] masked_fill
  • [ ] masked_select
  • [x] #6557
  • [ ] matrix_power
  • [ ] matrix_exp
  • [x] #5836
  • [ ] maximum
  • [x] #7505
  • [x] #15764
  • [x] #11333
  • [ ] nanmedian
  • [x] #5826
  • [ ] #7464
  • [x] mm
  • [ ] smm
  • [ ] mode
  • [x] #17236
  • [x] #6072
  • [ ] msort
  • [x] mul
  • [x] mul_
  • [ ] #14573
  • [ ] multiply_
  • [ ] multinomial
  • [ ] mv
  • [ ] mvlgamma
  • [ ] mvlgamma_
  • [ ] nansum
  • [x] #17232
  • [ ] narrow_copy
  • [ ] #7383
  • [ ] nan_to_num
  • [ ] nan_to_num_
  • [x] #7646
  • [ ] ne_
  • [x] #15699
  • [ ] not_equal_
  • [x] #7509
  • [ ] neg_
  • [ ] negative
  • [ ] negative_
  • [ ] nelement
  • [ ] nextafter
  • [ ] nextafter_
  • [x] nonzero
  • [x] norm
  • [x] normal_
  • [ ] numel
  • [x] #9344
  • [ ] orgqr
  • [ ] ormqr
  • [ ] outer
  • [x] #7500
  • [ ] pin_memory
  • [ ] pinverse
  • [ ] polygamma
  • [ ] polygamma_
  • [ ] positive
  • [x] #6827
  • [x] #6829
  • [x] prod
  • [ ] put_
  • [ ] qr
  • [ ] qscheme
  • [ ] quantile
  • [ ] nanquantile
  • [ ] q_scale
  • [ ] q_zero_point
  • [ ] q_per_channel_scales
  • [ ] q_per_channel_zero_points
  • [ ] q_per_channel_axis
  • [ ] rad2deg
  • [ ] random_
  • [x] #13620
  • [x] #6513
  • [ ] reciprocal_
  • [ ] record_stream
  • [ ] register_hook
  • [x] #14496
  • [ ] remainder_
  • [ ] renorm
  • [ ] renorm_
  • [x] #11200
  • [ ] repeat_interleave
  • [ ] requires_grad
  • [ ] requires_grad_
  • [x] reshape
  • [x] #10149
  • [ ] resize_
  • [ ] resize_as_
  • [ ] retain_grad
  • [ ] retains_grad
  • [ ] roll
  • [ ] rot90
  • [x] round
  • [ ] #17513
  • [x] rsqrt
  • [ ] rsqrt_
  • [ ] scatter
  • [ ] #16184
  • [ ] scatter_add_
  • [ ] scatter_add
  • [ ] scatter_reduce_
  • [ ] scatter_reduce
  • [ ] select
  • [ ] select_scatter
  • [ ] set_
  • [ ] share_memory_
  • [x] #14779
  • [x] #5778
  • [x] sigmoid_
  • [x] #14287
  • [ ] #17511
  • [ ] signbit
  • [ ] #16013
  • [ ] sgn_
  • [x] #5040
  • [x] #5041
  • [ ] sinc
  • [ ] sinc_
  • [x] #7562
  • [x] #7563
  • [x] #5723
  • [x] #5771
  • [x] #14205
  • [ ] arcsinh_
  • [x] #7020
  • [ ] slogdet
  • [ ] slice_scatter
  • [x] #7798
  • [x] #11153
  • [ ] sparse_mask
  • [ ] sparse_dim
  • [x] #15000
  • [x] #12731
  • [x] #14048
  • [ ] square_
  • [x] #7642
  • [ ] #15844
  • [x] #14994
  • [ ] stft
  • [ ] storage_type
  • [ ] stride
  • [ ] #13684
  • [x] #13992
  • [ ] #13990
  • [x] #13992
  • [x] #7402
  • [ ] sum_to_size
  • [ ] svd
  • [ ] swapaxes
  • [ ] swapdims
  • [ ] symeig
  • [x] #13553
  • [ ] t_
  • [x] #11154
  • [ ] tile
  • [x] to
  • [ ] to_mkldnn
  • [ ] take
  • [x] take_along_dim
  • [x] #5554
  • [x] #6821
  • [x] #6743
  • [x] #6744
  • [x] #6867
  • [x] #6868
  • [x] #6869
  • [x] #6870
  • [x] tolist
  • [x] topk
  • [ ] to_dense
  • [ ] to_sparse
  • [ ] to_sparse_csr
  • [ ] to_sparse_csc
  • [ ] to_sparse_bsr
  • [ ] to_sparse_bsc
  • [ ] trace
  • [x] #7560
  • [x] #7561
  • [ ] triangular_solve
  • [x] #7843
  • [ ] tril_
  • [ ] triu
  • [ ] triu_
  • [ ] true_divide
  • [ ] true_divide_
  • [x] #14302
  • [x] #14303
  • [x] #7844
  • [x] #7845
  • [x] unbind
  • [ ] unflatten
  • [x] unfold
  • [ ] uniform_
  • [ ] unique
  • [ ] unique_consecutive
  • [x] unsqueeze
  • [x] unsqueeze_
  • [ ] values
  • [x] #17233
  • [ ] vdot
  • [x] view
  • [x] #6299
  • [x] #10786
  • [x] where
  • [ ] xlogy
  • [ ] xlogy_
  • [ ] zero_
  • [ ] backward

iamjameskeane avatar Aug 25 '22 11:08 iamjameskeane

Hey can you please elaborate on that. I mean, what does adding PyTorch instance method to ivy means. @jkeane508

Thanks.

Anindyadeep avatar Aug 25 '22 17:08 Anindyadeep

Hey can you please elaborate on that. I mean, what does adding PyTorch instance method to ivy means. @jkeane508

Thanks.

Hey @Anindyadeep ,

These are new frontend tasks to be completed, however there still needs to be some documentation drawn up and some examples set. Im forgot to convert this to draft, so I am going to close it for now and reopen when its ready :)

Sorry for the confusion!

iamjameskeane avatar Aug 26 '22 08:08 iamjameskeane

@jkeane508 okay I get it. Thanks for updating. I was also looking for examples on YouTube about contributing and front end api examples. Ivy is doing really great and looking forward to contributing to this repo.

Anindyadeep avatar Aug 26 '22 09:08 Anindyadeep

acos which I implemented, went missing from the current master branch

Viditagarwal7479 avatar Oct 25 '22 18:10 Viditagarwal7479

acos which I implemented, went missing from the current master branch

Hi @Viditagarwal7479 thanks for flagging this let me look into it🙂

fnhirwa avatar Oct 25 '22 19:10 fnhirwa

Everyone please keep in mind that the correct way to link an issue to the list is to comment "- [ ] #issue_number".

AnnaTz avatar Feb 12 '23 15:02 AnnaTz

Can I implement all the bitwise functions for frontend? I have implemented bitwise xor last night but I think @jatinS-dev has opened a PR for it. So I am planning on working on other torch frontend functions

AniTho avatar Mar 23 '23 12:03 AniTho

Shifting?

AniTho avatar Mar 24 '23 07:03 AniTho

  • [ ] #13056

jatinS-dev avatar Mar 24 '23 08:03 jatinS-dev

  • [ ] #18970

natek-1 avatar Jul 07 '23 20:07 natek-1

#20191

jaysilver-5 avatar Jul 23 '23 23:07 jaysilver-5

isreal #21267

muhammadwaqas476074 avatar Aug 04 '23 02:08 muhammadwaqas476074

  • [ ] #21557

NiteshK84 avatar Aug 09 '23 18:08 NiteshK84

  • [ ] #21615

Sarvesh-Kesharwani avatar Aug 10 '23 21:08 Sarvesh-Kesharwani

Could you kindly track this issue? I assigned myself by commenting here. The other person did not adhere to the procedure; hence I was unaware of its existence. Thanks.

  • [ ] https://github.com/unifyai/ivy/issues/21752

he11owthere avatar Aug 12 '23 19:08 he11owthere

Could you kindly track this issue? I assigned myself by commenting here. The other person did not adhere to the procedure; hence I was unaware of its existence. Thanks.

Hi @he11owthere, it seems the divide subtask was already linked to an issue when you tried to reserve it. #20933 was opened and referenced 2 weeks ago, while #21752 (your issue) only 2 days ago.

AnnaTz avatar Aug 14 '23 09:08 AnnaTz

Hello, @AnnaTz,

I started working on the divide task since it was not linked to any issue. I commented here to associate it with my issue https://github.com/unifyai/ivy/issues/21752. However, a few hours later, someone else commented the issue name, which was opened 2 weeks ago but not linked here, and that action linked the issue https://github.com/unifyai/ivy/issues/20933 here.

he11owthere avatar Aug 14 '23 10:08 he11owthere

@AnnaTz You can check the below image, someone else commented that issue name https://github.com/unifyai/ivy/issues/20933 here (for the first time) after my comment, link to their PR https://github.com/unifyai/ivy/pull/21763. image

he11owthere avatar Aug 14 '23 10:08 he11owthere

Hi @AnnaTz, I was trying to solve the issue ( #20933 ) which was opened 2 weeks ago. I have closed the repo knowing that @he11owthere have created a pull request 5 hours ago. @he11owthere created the same issue here in #21752.

Did you create this unknowingly @he11owthere ?

mahendran-narayanan avatar Aug 14 '23 10:08 mahendran-narayanan

@mahendran-narayanan As I mentioned in my previous comment, the divide method was not linked to any issue. I had no way of knowing that someone else had initially created it.

Could you kindly track this issue? I assigned myself by commenting here. The other person did not adhere to the procedure; hence I was unaware of its existence. Thanks.

he11owthere avatar Aug 14 '23 10:08 he11owthere

Thanks for closing your PR @mahendran-narayanan. Not sure what happened with ivy-bot but it does seem that @he11owthere tried to link it first. @he11owthere I have now linked your issue to the list.

AnnaTz avatar Aug 14 '23 13:08 AnnaTz

Hi @AnnaTz , how do i change my assignee to this PR #21618, its been 1 week since i submitted it, but there is no review. Thanks

NiteshK84 avatar Aug 16 '23 21:08 NiteshK84

  • [ ] https://github.com/unifyai/ivy/issues/22689

he11owthere avatar Aug 28 '23 13:08 he11owthere

  • [ ] https://github.com/unifyai/ivy/issues/22715

he11owthere avatar Aug 28 '23 20:08 he11owthere

  • [ ] #22742

imessam avatar Aug 29 '23 14:08 imessam

  • [ ] #22782

ArsalanAli915 avatar Aug 30 '23 11:08 ArsalanAli915

  • [ ] #22823

NiteshK84 avatar Aug 31 '23 09:08 NiteshK84

  • [ ] #22828

NiteshK84 avatar Aug 31 '23 10:08 NiteshK84

bernoulli_ https://github.com/unifyai/ivy/issues/22976

Aaryan562 avatar Sep 03 '23 12:09 Aaryan562

  • [ ] #23071

beandkay avatar Sep 05 '23 11:09 beandkay

Hello @jkeane508

I created this issue #23675 to work on and following the docs, I made sure to check for all of these things when choosing it from the todo list:

  • is not marked as completed with a tick
  • does not have an issue created and
  • is not mentioned in the comments.

but when i started to work on it, i noticed that the .ndim method is already implemented in the pytorch frontend: https://github.com/unifyai/ivy/blob/73916b3ac4cb90eea753e8a011e79b9a24cfe7b5/ivy/functional/frontends/torch/tensor.py#L75-L77

daspartho avatar Sep 16 '23 18:09 daspartho