ivy icon indicating copy to clipboard operation
ivy copied to clipboard

update setting_up.rst

Open Satarupa22-SD opened this issue 9 months ago • 5 comments

PR Description

Updates the path for requirements.txt file present in the requirements directory

Related Issue

Checklist

  • [ ] Did you add a function?
  • [ ] Did you add the tests?
  • [ ] Did you run your tests and are your tests passing?
  • [ ] Did pre-commit not fail on any check?
  • [ ] Did you follow the steps we provided?

Socials

Satarupa22-SD avatar May 02 '24 11:05 Satarupa22-SD

@Sam-Armstrong please look into it. Thanks :)

Satarupa22-SD avatar May 02 '24 11:05 Satarupa22-SD

@Satarupa22-SD did we establish in the discord discussion that this doc was actually correct because it was referring to the requirements in the ivy/ivy_tests/array_api_testing/test_array_api folder?

Sam-Armstrong avatar May 02 '24 12:05 Sam-Armstrong

@Sam-Armstrong we were referring to separate sections in the documentation which is why there was confusion, someone pointed that out later 😅. However, please feel free to look into it again. 🙂

Satarupa22-SD avatar May 02 '24 13:05 Satarupa22-SD

@Sam-Armstrong however I do feel the change made is correct because if you would notice the previous commands all of them are referencing the files inside the requirements directory. :)

Satarupa22-SD avatar May 02 '24 13:05 Satarupa22-SD

@Satarupa22-SD I think this is correct for Installing array API testing dependencies, as there is a requirements.txt file under the ivy/ivy_tests/array_api_testing/test_array_api directory, and this section of the docs is specifically referring to the dependencies for array api testing.

Sam-Armstrong avatar May 03 '24 09:05 Sam-Armstrong

Based on the comments from @Sam-Armstrong it seems like its best to close this PR. Please feel free to suggest otherwise @Satarupa22-SD

Ishticode avatar May 13 '24 10:05 Ishticode