ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Published 20 hours ago • verified publisher icon Transpile-AI

Fix Ivy Failing Test: jax - activations.gelu

Open MuhammadNizamani opened this issue 1 year ago • 5 comments

PR Description

All test are passing locally gelu

Related Issue

Closes #28160 Closes #28154

Checklist

  • [ ] Did you add a function?
  • [ ] Did you add the tests?
  • [x] Did you run your tests and are your tests passing?
  • [x] Did pre-commit not fail on any check?
  • [x] Did you follow the steps we provided?

Socials

MuhammadNizamani avatar Feb 02 '24 10:02 MuhammadNizamani

Hi @MuhammadNizamani, test is failing for one of the backends here is the decorator you can use to reproduce the failure @reproduce_failure('6.97.1', b'AXicY2QAAsYDDxhggBFK58BFADLuAhA=') Thanks image image

Sarvesh-Kesharwani avatar Feb 04 '24 10:02 Sarvesh-Kesharwani

@Sarvesh-Kesharwani I will look into it Thanks for review

MuhammadNizamani avatar Feb 04 '24 11:02 MuhammadNizamani

Hii @MuhammadNizamani the changes you made also not good float16 dtype the tol value you kept more then 1e-2 it's not making any sense here.

samthakur587 avatar Feb 04 '24 20:02 samthakur587

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Feb 27 '24 05:02 ivy-seed

i am working on it

MuhammadNizamani avatar Mar 02 '24 04:03 MuhammadNizamani