ivy icon indicating copy to clipboard operation
ivy copied to clipboard

feat: add increment method to paddle frontend

Open muhammadhammad-tech opened this issue 1 year ago • 9 comments

Fixes https://github.com/unifyai/ivy/issues/26215

PR Description Implemented the increment method in both math.py, test_math.py, tensor.py, and test_tensor.py.

Related Issue Close https://github.com/unifyai/ivy/issues/26215

Checklist

  • [x] Did you add a function?

  • [x] Did you add the tests?

  • [x] Did you run your tests and are your tests passing?

  • [x] Did pre-commit not fail on any check?

  • [x] Did you follow the steps we provided?

Socials

muhammadhammad-tech avatar Oct 17 '23 18:10 muhammadhammad-tech

really sorry for the mess i will be careful in my other PRs this one is just terrible, i am unable to resolve docs/demos conflict. will be looking forward for your response and guidance thank you @KareemMAX

muhammadhammad-tech avatar Oct 17 '23 18:10 muhammadhammad-tech

@juliagsy

muhammadhammad-tech avatar Oct 17 '23 18:10 muhammadhammad-tech

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

github-actions[bot] avatar Oct 18 '23 00:10 github-actions[bot]

really sorry for the mess i will be careful in my other PRs this one is just terrible, i am unable to resolve docs/demos conflict. will be looking forward for your response and guidance thank you @KareemMAX

No worries at all, you may revert the commits that involved the doc/demos conflict. Then you may use your IDE's GUI to not commit that change instead of always commiting all files

KareemMAX avatar Oct 18 '23 11:10 KareemMAX

@KareemMAX is it good ? thank you.

muhammadhammad-tech avatar Oct 22 '23 17:10 muhammadhammad-tech

hey @KareemMAX kindly can you check it.. thank you

muhammadhammad-tech avatar Oct 25 '23 22:10 muhammadhammad-tech

hey @KareemMAX kindly can you check it.. thank you

Hey @muhammadhammad-tech, I'll leave it with @MuhammedAshraf2020 as he is your primary assignee.

KareemMAX avatar Oct 26 '23 13:10 KareemMAX

@MuhammedAshraf2020 kindly can you review it thank you

muhammadhammad-tech avatar Oct 27 '23 04:10 muhammadhammad-tech

Hey @muhammadhammad-tech, thank you for your contribution 🙏🏻 we appreciate it too much ☺️ will review it soon. Thanks

MuhammedAshraf2020 avatar Oct 27 '23 04:10 MuhammedAshraf2020

Hi @muhammadhammad-tech please resolve the merge conflicts.

Sarvesh-Kesharwani avatar Dec 28 '23 08:12 Sarvesh-Kesharwani

@Sarvesh-Kesharwani could you check

muhammadhammad-tech avatar Dec 30 '23 21:12 muhammadhammad-tech

Thank you very much for the PR. Closing this due to lack of activity with changes requested remaining unresolved for over a month. Please feel free to reopen if you would like to continue working on this. :)

Ishticode avatar Mar 28 '24 11:03 Ishticode