ivy icon indicating copy to clipboard operation
ivy copied to clipboard

feat(framework): refactor as_ivy_dev and as_native to check for available device on local hardware

Open abdulasiraj opened this issue 2 years ago • 5 comments

PR Description

Related Issue

Close #

Checklist

  • [ ] Did you add a function?
  • [ ] Did you add the tests?
  • [ ] Did you run your tests and are your tests passing?
  • [ ] Did pre-commit not fail on any check?
  • [ ] Did you follow the steps we provided?

Socials

abdulasiraj avatar Oct 09 '23 15:10 abdulasiraj

Hey @vedpatwardhan, This is the new PR for refactoring devices methods. I just implemented for Jax now so it'll be easy to review. when it's approved, it doesn't take much time for other frameworks on the same pattern/. thanks!

abdulasiraj avatar Oct 09 '23 15:10 abdulasiraj

If you're on the GPU. please test locally to confirm things. thanks!

abdulasiraj avatar Oct 09 '23 15:10 abdulasiraj

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

github-actions[bot] avatar Oct 09 '23 16:10 github-actions[bot]

Hey @vedpatwardhan, this is final now. I tried to generalize as much as i can. please have an other look. thanks!

abdulasiraj avatar Oct 11 '23 06:10 abdulasiraj

Hey @vedpatwardhan, it final now hopefully. mind taking another look? thanks!

abdulasiraj avatar Oct 11 '23 15:10 abdulasiraj

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Mar 23 '24 05:03 ivy-seed

Closing this due to inactivity after changes were requested for over 6 months plus its been labelled stale for some time. Please feel free to reopen if you would like to continue working on this. Thank you :)

Ishticode avatar Mar 30 '24 15:03 Ishticode