ivy icon indicating copy to clipboard operation
ivy copied to clipboard

index_add_

Open imsoumya18 opened this issue 1 year ago • 1 comments

PR Description

index_add_ method in Paddla FrontEnd

Related Issue

index_add_ #26393

Close #26393

Checklist

  • [x] Did you add a function?
  • [x] Did you add the tests?
  • [ ] Did you run your tests and are your tests passing?
  • [ ] Did pre-commit not fail on any check?
  • [ ] Did you follow the steps we provided?

Socials

Twitter

imsoumya18 avatar Oct 08 '23 05:10 imsoumya18

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

github-actions[bot] avatar Oct 08 '23 05:10 github-actions[bot]

@NiteshK84 can u please have a look at it? Same as #26394 but, in place version.

imsoumya18 avatar Jan 09 '24 14:01 imsoumya18

@NiteshK84 can u please have a look at it? Same as #26394 but, in place version.

Hi @imsoumya18, Could you kindly start by initiating the creation of a new issue for incorporating the index_add function into the IvyFunctional API as suggested by @hello-fri-end ?

NiteshK84 avatar Jan 10 '24 12:01 NiteshK84

@NiteshK84 can u please have a look at it? Same as #26394 but, in place version.

Hi @imsoumya18, Could you kindly start by initiating the creation of a new issue for incorporating the index_add function into the IvyFunctional API?

as per the policy, we will have to update your previous function implementation as well.

NiteshK84 avatar Jan 10 '24 12:01 NiteshK84

@NiteshK84 can u please have a look at it? Same as #26394 but, in place version.

Hi @imsoumya18, Could you kindly start by initiating the creation of a new issue for incorporating the index_add function into the IvyFunctional API as suggested by @hello-fri-end ?

I tried that. But, other devs didn't merge that saying a new functional API is unnecessary for such small reason and gave a green signal to go forward with this approach. That's why this is stuck for a long time. I'll try to pass the tests and let u know.

imsoumya18 avatar Jan 10 '24 12:01 imsoumya18

@NiteshK84 can u please have a look at it? Same as #26394 but, in place version.

Hi @imsoumya18, Could you kindly start by initiating the creation of a new issue for incorporating the index_add function into the IvyFunctional API as suggested by @hello-fri-end ?

I tried that. But, other devs didn't merge that saying a new functional API is unnecessary for such small reason and gave a green signal to go forward with this approach. That's why this is stuck for a long time. I'll try to pass the tests and let u know.

If that is the case, then you can sure go forward and work on fixing the remaining failing test cases.

NiteshK84 avatar Jan 10 '24 12:01 NiteshK84

@NiteshK84 all tests passed !!

imsoumya18 avatar Jan 13 '24 07:01 imsoumya18

@NiteshK84 all tests are passing now. Have a look at it...

imsoumya18 avatar Jan 15 '24 13:01 imsoumya18

LGTM! image

NiteshK84 avatar Jan 18 '24 13:01 NiteshK84