ivy icon indicating copy to clipboard operation
ivy copied to clipboard
verified publisher icon Transpile-AI

feat(paddle frontend): add index_sample function

Open ksbharaj opened this issue 2 years ago • 10 comments

PR Description

Added Index_sample for Paddle

Related Issue

Close #26495

Checklist

  • [X] Did you add a function?
  • [X] Did you add the tests?
  • [X] Did you run your tests and are your tests passing?
  • [X] Did pre-commit not fail on any check?
  • [X] Did you follow the steps we provided?

Socials

ksbharaj avatar Oct 07 '23 23:10 ksbharaj

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

github-actions[bot] avatar Oct 07 '23 23:10 github-actions[bot]

Hi @Sam-Armstrong and @KareemMAX. I raised this PR to address the requested change. Kindly let me know if you require any additional info to help merge this to the main branch. Thank you

ksbharaj avatar Oct 10 '23 14:10 ksbharaj

@ksbharaj please could you add the corresponding frontend test? https://unify.ai/docs/ivy/overview/deep_dive/ivy_frontends_tests.html#ivy-frontend-tests

Sam-Armstrong avatar Oct 10 '23 16:10 Sam-Armstrong

Hi @Sam-Armstrong. I believe this is already there from a previous PR. Please check:

ivy/ivy_tests/test_ivy/test_frontends/test_paddle /test_search.py

and the function test_paddle_index_sample()

Let me know if that's the correct test, and if anything else is needed.

ksbharaj avatar Oct 11 '23 03:10 ksbharaj

Hi @Sam-Armstrong. I believe this is already there from a previous PR. Please check:

ivy/ivy_tests/test_ivy/test_frontends/test_paddle /test_search.py

and the function test_paddle_index_sample()

Let me know if that's the correct test, and if anything else is needed.

Hi @Sam-Armstrong. Have you had a chance to review this? Kindly let me know if you need any more information from me

ksbharaj avatar Oct 12 '23 02:10 ksbharaj

@ksbharaj we also need a test in ivy/ivy_tests/test_ivy/test_frontends/test_paddle /test_tensor.py, as you've implemented a tensor method here.

Sam-Armstrong avatar Oct 13 '23 09:10 Sam-Armstrong

Hey @Sam-Armstrong I've added the test to test_paddle/test_tensor/test_tensor.py as requested. Kindly let me know if there's anything else required.

ksbharaj avatar Oct 14 '23 16:10 ksbharaj

Hi @Sam-Armstrong. I added the tests, but I think this still needs some rectifications. I think I am facing some issues getting the tests to work locally, so I can't debug effectively. If you have the chance, please review my code and kindly let me know how I can improve it (I'm eager to learn and improve here)

ksbharaj avatar Oct 24 '23 13:10 ksbharaj

Hi @Sam-Armstrong. Please do let me know. I would like to continue contributing but just need some help on how to do it correctly. Thank you

ksbharaj avatar Oct 31 '23 15:10 ksbharaj

Hi @ksbharaj, sorry for the slow reply. I'm not exactly sure what's going wrong with the test unfortunately, the other tests in the file seem to be failing for me also. I'll continue looking into it, but maybe for the time being could you resolve the merge conflicts with main? Thanks!

Sam-Armstrong avatar Nov 01 '23 14:11 Sam-Armstrong

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Mar 24 '24 05:03 ivy-seed

Closing this due to inactivity for over 6 months. Please feel free to reopen if you would like to continue working on this. Thank you :)

Ishticode avatar Mar 30 '24 16:03 Ishticode