ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Published 20 hours ago • verified publisher icon Transpile-AI

feat(Jax-frontend): Add histogramdd to JAX Frontend

Open ThanhDuonghcmut opened this issue 1 year ago • 8 comments

PR Description

Related Issue #26298

Close #26298

Checklist

  • [x] Did you add a function?
  • [x] Did you add the tests?
  • [x] Did you run your tests and are your tests passing?
  • [x] Did pre-commit not fail on any check?
  • [x] Did you follow the steps we provided?

Socials

ThanhDuonghcmut avatar Oct 07 '23 07:10 ThanhDuonghcmut

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

github-actions[bot] avatar Oct 07 '23 07:10 github-actions[bot]

Hey, thanks for contributing! Please let me know once you've ticked off the items in the checklist and this is ready for review!

aparajith21 avatar Oct 14 '23 18:10 aparajith21

Screenshot_2023-10-15-07-21-27-206_com.github.android-edit.jpg Could you kindly help me to understand what this warning means? Does it affect my code quality?

Screenshot_2023-10-15-07-21-59-343_com.github.android-edit.jpg And also, as my code runs with JAX frontend histogramdd, could I ask why I got this error about numpy_exp2?

I really appreciate your reviews. Please kindly help me clarify them. Thank you very much.

ThanhDuonghcmut avatar Oct 15 '23 00:10 ThanhDuonghcmut

Hi @aparajith21 , I've checked all the ticks on the items. Could you please give me a review for my code?

ThanhDuonghcmut avatar Oct 16 '23 03:10 ThanhDuonghcmut

Hi @aparajith21 , could you kindly have a review for my code?

ThanhDuonghcmut avatar Oct 19 '23 02:10 ThanhDuonghcmut

Thanks for contributing! All seems good, test failures seem unrelated to PR, but could you please remove usage of external libraries like math and operator and substitute their usage with either built in python functions or ivy functions

aparajith21 avatar Oct 24 '23 13:10 aparajith21

Hi @aparajith21 , I've replaced the external libraries with built-in Python or Ivy functions. However, it produced more failures. Could you kindly have a re-review of what is happening and help me to explain the reason of my failures, as I don't understand what the failures said? Thank you very much.

ThanhDuonghcmut avatar Oct 27 '23 03:10 ThanhDuonghcmut

Hello @aparajith21 , could you please review my code? I've removed the external libs as you requested

ThanhDuonghcmut avatar Nov 08 '23 11:11 ThanhDuonghcmut

Hello @Fayad-Alman, could you please review my code? Thank you very much

ThanhDuonghcmut avatar Dec 29 '23 11:12 ThanhDuonghcmut

waiting on fresh ci run

Ishticode avatar Mar 03 '24 11:03 Ishticode

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Mar 25 '24 05:03 ivy-seed

Closing this due to inactivity. Please feel free to reopen if you would like to continue working on this. Thanks :)

Ishticode avatar Apr 09 '24 22:04 Ishticode