ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Published 20 hours ago • verified publisher icon Transpile-AI

Added l1_l2 frontend

Open ahlag opened this issue 2 years ago • 4 comments

Signed-off-by: Chang Yong Lik [email protected]

Description

  • Added l1_l2

Resolves https://github.com/unifyai/ivy/issues/2348

How was this patch tested?

TBD

Does this PR introduce any user-facing changes?

Allows users to run l1_l2 from Tensorflow

ahlag avatar Jul 29 '22 12:07 ahlag

@abdrahmandiab Hi, would love to have some feedbacks for L1L2 regularizers.

ahlag avatar Jul 29 '22 13:07 ahlag

Hey there! Thanks a lot for this feature! We'll be looking into feature extensions after our next release soon!

juliagsy avatar Jul 30 '22 07:07 juliagsy

@juliagsy Hey thank you for your reply. Should we keep this PR in WIP

ahlag avatar Jul 30 '22 08:07 ahlag

Discussed in another separate discussion. Refer: https://github.com/unifyai/ivy/discussions/2051#discussioncomment-3280274

ahlag avatar Jul 30 '22 13:07 ahlag

Hi @ahlag, Really sorry for the inconvenience and confusion! The issue solved in this PR is indeed part of the current applicant task list, and therefore it should not have the "Next Release" label. However, it appears this function will require some special attention since it doesn't have a very generalizable return type across backends, therefore it is tricky to handle the frontend implementation for. Definitely a mistake on our part, and we will update the description for it soon.

For the time being and to speed up your application, could you attempt to solve another issue from the ToDo labeled ones? 😅

Apologies for the confusion again, and thank you so much! Please let me know if you have any questions.

abdrahmandiab avatar Jul 31 '22 19:07 abdrahmandiab

Hi @abdrahmandiab,

Thank you so much for your reply! I will hold up the test for now and focus on other tasks. Really thank you!

ahlag avatar Jul 31 '22 22:07 ahlag