ivy
ivy copied to clipboard
Map
Pull request for issue #2094
#2094
Hi @Psychofun the changes you made were not needed. The lambda
is only to be replaced for backends. You just need to add the docstring examples for the map
function following the docstring examples guide. Please feel free to ask any more queries you might have.
Hi there! @RickSanchezStoic I've added some examples for map. I'll be waiting for your review and comments. Thanks.
@Psychofun kindly fix the lint errors for the file you made changes to. Also, once you make the changes, do bash ./merge_with_upstream
to update your fork with unifyai:master. Ths is needed to update the docstring tests.Thanks
@RickSanchezStoic I made the corrections.
One question. Using ./merge_with_upstream
is equivalent to use the Update branch
button?
Thank you!
@RickSanchezStoic I made the corrections. One question. Using
./merge_with_upstream
is equivalent to use theUpdate branch
button? Thank you!
Yes, in the end you should just make sure that your fork is not behind the master
@Psychofun you need to fix the docstring errors for your specific functions. Kindly check the contributor guide and update. Feel free to ask any queries. Thanks!
@RickSanchezStoic I have corrected the errors, I think there aren't anymore. Let me know what else is needed to carry out the PR. Thanks for your time.
@Psychofun Check the docstring log and you will find map
is still there in the list of failing functions.
@RickSanchezStoic I checked and fixed it. I hope now all is working well. I'm waiting your review. Thanks for your feedback.
Looks good to me!