ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Map

Open Psychofun opened this issue 2 years ago • 3 comments

Pull request for issue #2094

Psychofun avatar Jul 21 '22 18:07 Psychofun

#2094

Psychofun avatar Jul 23 '22 20:07 Psychofun

Hi @Psychofun the changes you made were not needed. The lambda is only to be replaced for backends. You just need to add the docstring examples for the map function following the docstring examples guide. Please feel free to ask any more queries you might have.

RickSanchezStoic avatar Jul 24 '22 12:07 RickSanchezStoic

Hi there! @RickSanchezStoic I've added some examples for map. I'll be waiting for your review and comments. Thanks.

Psychofun avatar Jul 29 '22 00:07 Psychofun

@Psychofun kindly fix the lint errors for the file you made changes to. Also, once you make the changes, do bash ./merge_with_upstream to update your fork with unifyai:master. Ths is needed to update the docstring tests.Thanks

RickSanchezStoic avatar Aug 01 '22 06:08 RickSanchezStoic

@RickSanchezStoic I made the corrections. One question. Using ./merge_with_upstream is equivalent to use the Update branch button? Thank you!

Psychofun avatar Aug 01 '22 22:08 Psychofun

@RickSanchezStoic I made the corrections. One question. Using ./merge_with_upstream is equivalent to use the Update branch button? Thank you!

Yes, in the end you should just make sure that your fork is not behind the master

RickSanchezStoic avatar Aug 03 '22 06:08 RickSanchezStoic

@Psychofun you need to fix the docstring errors for your specific functions. Kindly check the contributor guide and update. Feel free to ask any queries. Thanks!

RickSanchezStoic avatar Aug 03 '22 06:08 RickSanchezStoic

@RickSanchezStoic I have corrected the errors, I think there aren't anymore. Let me know what else is needed to carry out the PR. Thanks for your time.

Psychofun avatar Aug 03 '22 21:08 Psychofun

@Psychofun Check the docstring log and you will find map is still there in the list of failing functions.

RickSanchezStoic avatar Aug 04 '22 06:08 RickSanchezStoic

@RickSanchezStoic I checked and fixed it. I hope now all is working well. I'm waiting your review. Thanks for your feedback.

Psychofun avatar Aug 04 '22 21:08 Psychofun

Looks good to me!

RickSanchezStoic avatar Aug 08 '22 05:08 RickSanchezStoic