Transpile-AI
min #1473
#1473
JAX documentation suggests that it support the out argument, so could you please add that? I also see that you have missing container and array instance methods. Other than that, could you also resolve merge conflicts? I'll have a look again after these changes are made!
Thanks for the review MarShaikh, I have just adjusted my code and committed to fix, after that pushed again.
Requested changes have been made, new review when possible please.
The .idea files re-appeared after I deleted that for some reason. It is strange that you did not see any updates? No worries though, I'm re-pushing.
.idea files keep reappearing, I deleted them many times already. Do I need to know something particular?
I also fixed merge conflicts yesterday evening, new conflicts appeared? I am kinda confused. Though, will have a look.
After some experimentation, it turns out that It breaks if I remove the .idea files for some reason, can we talk on this real time in discord? Other than that, it looks good. No conflicts. Ready to be reviewed!
After some experimentation, it turns out that It breaks if I remove the .idea files for some reason, can we talk on this real time in discord? Other than that, it looks good. No conflicts. Ready to be reviewed!
Hi, I'm not sure why it would break. It shouldn't since you are only removing .idea files and only the docstrings of the functions are being changed. Also, once you remove the .idea files it still shows up in the git .diff as removed, you can filter to remove deleted files and it should be good to go.
Filtering to remove deleted files did not work out well, still having .idea related conflicts. As of now, my only conflicts are .idea ones. Any other suggestions please?
Filtering to remove deleted files did not work out well, still having .idea related conflicts. As of now, my only conflicts are .idea ones. Any other suggestions please?
Easiest way to fix this, I would suggest is just to close this PR, create a new one and only push the changes required. I'm not sure how to fix the .idea conflicts either without changing the branch and pruning your current one.
I suppose that the same thing will happen even if I do this stuff again all over from the beginning. So I am planning to solve it here. In regard to that, will do some search, ask in discord, ask friends etc. Therefor please, if you confront something you think would be beneficial, don't hesitate to share with me!
In the last commit I replaced my .idea files with the default .idea files. So far so good, no conflicts! Requesting a review please.
In the last commit I replaced my .idea files with the default .idea files. So far so good, no conflicts! Requesting a review please.
Sounds good, I'll take a look!
Conflicts have been solved until the next change in the code, to say the least. Therfor please, requesting a review before someone changes something!
I did not include .idea files, and fixed the conflicts. Requesting a review please.
I just realised, the issue connected to this isn't open by you. That's unfortunate. I would recommend you to open a new issue, comment the parent issue name in the issue: "Reformat statistical #812". You should then comment "Closes #issue number" here in the PR. Finally, I would recommend you to pull from upstream as a number of changes has been made since you last opened this PR. You would then notice that the only changes you need to make is for the array instance methods and the container instance methods. Everything else is done. Also, please remove the mxnet folder from your PR as due to a change of policy we aren't supporting MXNet as of now. Finally, of the min function in
ivy/functional/ivy/statistical.pywas incorrect. Thanks, please update this and request for a review.
As shown in the image this issue was opened by me. I'm having a hard time to figure out what you meant.
Besides the previous comment, even if I would need to re-open this issue I suppose that I will not be able to do so since someone has already finished it. So what do you propose at this case?
I just realised, the issue connected to this isn't open by you. That's unfortunate. I would recommend you to open a new issue, comment the parent issue name in the issue: "Reformat statistical #812". You should then comment "Closes #issue number" here in the PR. Finally, I would recommend you to pull from upstream as a number of changes has been made since you last opened this PR. You would then notice that the only changes you need to make is for the array instance methods and the container instance methods. Everything else is done. Also, please remove the mxnet folder from your PR as due to a change of policy we aren't supporting MXNet as of now. Finally, of the min function in
ivy/functional/ivy/statistical.pywas incorrect. Thanks, please update this and request for a review.
As shown in the image this issue was opened by me. I'm having a hard time to figure out what you meant.
That's the PR that you have opened, not an issue.
Had to use merge_with_upstream in order to counter merge conflicts so that might be why it got mixed. I'm just guessing, since I had it adjusted as stated.
There's one final error in the
run-docstrings-testrelating to thecontainer/statistical.pyfile remaining. Please have a look! Thanks, and then it should be ready to merge.
As shown in the screenshot there is not any errors in container/statistical.py. Could you please explain it more detailed?
Can you check the numpy style docstrings error and fix it. Indentation error still exists. Please request for a review after you've resolved these issues!
I managed to fix the indent error but there are 2 more errors that I could not yet figure out. Could you assist me on this please? Here they are:
- test-docstrings / run-docstring-tests (pull_request)
- test-array-api / run-array-api-tests (tensorflow, linalg) (pull_request)
Other than those, it is ready to be reviewed.
LGTM! The other errors aren't caused by your PR. Thanks for the contribution! 🌟
MarShaikh, thank you for your patience and assistance! It has been a solid journey for me, learnt a ton. I hereby would like to thank Ivy Team for this opportunity as well, very much appreciated Ivy people!