ivy icon indicating copy to clipboard operation
ivy copied to clipboard

EHN: Adding bmm method in paddle tesnor.py

Open MuhammadNizamani opened this issue 1 year ago • 1 comments

Closed #18021

MuhammadNizamani avatar Jun 29 '23 05:06 MuhammadNizamani

@YushaArif99 can you review this PR?

MuhammadNizamani avatar Jul 01 '23 12:07 MuhammadNizamani

Hi @MuhammadNizamani

Apologies for the late review. Have been extremely busy with work recently and so haven't had the time to review PRs sweat Could you kindly address the abovementioned point and re-request a review once that's done slightly_smiling_face

ok I will

MuhammadNizamani avatar Jul 10 '23 06:07 MuhammadNizamani

@YushaArif99 i don't think shape should be dynamic because when I change the shape test got fail cause was matmul function.

MuhammadNizamani avatar Jul 10 '23 09:07 MuhammadNizamani

@YushaArif99 i don't think shape should be dynamic because when I change the shape test got fail cause was matmul function.

I noticed the change you made in this commit and I'm a little confused on what you're trying to accomplish here:

shape=st.tuples(st.integers(3, 3), st.integers(3, 3), st.integers(3, 3)).filter(
            lambda x: x[0] == x[1]
        ),

What you need to do is generate 3-dimensional inputs such that their shapes are (b,n,k) and (b,k,m) so in a way you need to generate 4 integers (b,n,k,m) and you can then draw random arrays by using the helpers.array_values function and specifying the shapes to be those mentioned previously. Hope that makes sense 🙂

YushaArif99 avatar Jul 10 '23 10:07 YushaArif99