ivy icon indicating copy to clipboard operation
ivy copied to clipboard

added the numpy trace function frontend

Open Maxzeno opened this issue 1 year ago • 1 comments

Close #18013

Maxzeno avatar Jun 28 '23 23:06 Maxzeno

#18013

Maxzeno avatar Jun 29 '23 01:06 Maxzeno

Hi @Maxzeno,

Thank you so much for contributing to Ivy. To make sure Ivy is accurate and works the way it is meant to, we implement test functions for every frontend function we implement.

Could you please add the corresponding test function for trace? Thanks!

theRealBird avatar Jul 05 '23 13:07 theRealBird

@theRealBird Okay

Maxzeno avatar Jul 09 '23 11:07 Maxzeno

@theRealBird please review the changes I added a test function for trace as requested by you

Thanks

Maxzeno avatar Jul 25 '23 00:07 Maxzeno

@theRealBird @ivy-leaves @thecoder12 @edaehn @

Please review and merge my pull request

Maxzeno avatar Jul 30 '23 14:07 Maxzeno

Hi @Maxzeno, Thank you for your patience and adding the test function. However, it seems that the function is failing the tests. Could you please confirm and fix the errors?

theRealBird avatar Jul 31 '23 03:07 theRealBird

@theRealBird correct me if am wrong but the run_test 1, 14 and some other run test don't pass (I checked a lot of pull requests and noticed the same thing)

But I ran my own tests and they passed if you have the time check my latest commit to this pull request thank you for your time

Maxzeno avatar Jul 31 '23 09:07 Maxzeno

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Aug 16 '23 05:08 ivy-seed

@theRealBird please review again

Maxzeno avatar Aug 18 '23 16:08 Maxzeno

Hey! Many apologies for the delayed review of the previous assignee, I've just very recently been assigned to the pr and was about to check the test, but could you please update your branch to the latest master commit so that everything is up to date? I'll try to check back soonest possible on a working day, thanks!

juliagsy avatar Sep 29 '23 13:09 juliagsy

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

juliagsy avatar Oct 09 '23 13:10 juliagsy