ivy
ivy copied to clipboard
Added is_floating_point for Paddle frontend
Close #17970
@hmahmood24 please take a look, thanks !
If you are working on an open task, please edit the PR description to link to the issue you've created.
For more information, please check ToDo List Issues Guide.
Thank you :hugs:
Frontend Task Checklist
IMPORTANT NOTICE 🚨:
The Ivy Docs represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item to aid with the review process.
LEGEND 🗺:
- ❌ : Check item is not completed.
- ✅ : Check item is ready for review.
- 🆘 : Stuck/Doubting implementation (PR author should add comments explaining why).
- ⏩ : Check is not applicable to function (skip).
- 🆗 : Check item is implemented and does not require any edits.
CHECKS 📑:
-
- [x] ✅: The function/method definition is not missing any of the original arguments.
-
- [ ] ⏩: In case the function/method to be implemented is an alias of an existing function/method:
-
- [ ] ⏩: It is being declared as such by setting
fun1 = fun2
, rather than being re-implemented from scratch.
- [ ] ⏩: It is being declared as such by setting
-
- [ ] ⏩: The alias is added to the existing function/method's test in the
aliases
parameter ofhandle_frontend_test
/handle_frontend_method
.
- [ ] ⏩: The alias is added to the existing function/method's test in the
-
- [ ] ⏩: In case the function/method to be implemented is an alias of an existing function/method:
-
- [x] ✅: The naming of the function/method and its arguments exactly matches the original.
-
- [x] ✅: No defined argument is being ignored in the function/method's implementation.
-
- [ ] ⏩: In special cases where an argument's implementation should be pending due to an incomplete superset of an ivy function:
-
- [ ] ⏩: A descriptive comment has been left under the
Implement superset behavior
ToDo list in https://github.com/unifyai/ivy/issues/6406.
- [ ] ⏩: A descriptive comment has been left under the
-
- [ ] ⏩: A ToDo comment has been added prompting to pass the frontend argument to the ivy function whose behavior is to be extended.
-
- [ ] ⏩: In special cases where an argument's implementation should be pending due to an incomplete superset of an ivy function:
-
- [x] ✅: In case a frontend function is being added:
-
- [ ] ⏩: It is a composition of ivy functions.
-
- [ ] ⏩: In case the needed composition is long (using numerous ivy functions), a
Missing Function Suggestion
issue has been opened to suggest a new ivy function should be added to shorten the frontend implementation.
- [ ] ⏩: In case the needed composition is long (using numerous ivy functions), a
-
- [ ] ⏩:
@to_ivy_arrays_and_back
has been added to the function.
- [ ] ⏩:
-
- [x] ✅: In case a frontend function is being added:
-
- [x] ✅: In case a frontend method is being added:
-
- [x] ✅: It is composed of existing frontend functions or methods.
-
- [ ] ⏩: If a required frontend function has not yet been added, the method may be implemented as a composition of ivy functions, making sure that:
- [ ] ⏩:
@to_ivy_arrays_and_back
has been added to the method. - [ ] ⏩: A ToDo comment has been made prompting to remove the decorator and update the implementation as soon as the missing function has been added.
- [ ] ⏩:
- [ ] ⏩: If a required frontend function has not yet been added, the method may be implemented as a composition of ivy functions, making sure that:
-
- [x] ✅: In case a frontend method is being added:
-
- [x] ✅: The function/method's test has been added (except in the alias case mentioned in <2>):
-
- [x] ✅: All supported arguments are being generated in
handle_frontend_test
/handle_frontend_method
and passed totest_frontend_function
/test_frontend_method
.
- [x] ✅: All supported arguments are being generated in
-
- [x] ✅: The argument generation covers all possible supported values. Array sizes, dimensions, and axes adhere to the full supported set of the original function/method.
-
- [ ] ⏩: The
available_dtypes
parameter passed to the helper generating the function/method's input array is set tohelpers.get_dtypes("valid")
. If there are unsupported dtypes that cause the test to fail, they should be handled by adding@with_supported_dtypes
/@with_unsupported_dtype
to the function/method.
- [ ] ⏩: The
-
- [x] ✅: The function/method's test has been added (except in the alias case mentioned in <2>):
-
- [x] ✅: The PR is not introducing any test failures.
-
- [x] ✅: The lint checks are passing.
-
- [x] ✅: The implemented test is passing for all backends.
-
- [x] ✅: The PR is not introducing any test failures.
-
- [x] ✅: The PR
closes
aSub Task
issue linked to one of the open frontend ToDo lists.
- [x] ✅: The PR
-
- [x] ✅: The function/method and its test have been added to the correct
.py
files corresponding to the addressed ToDo list.
- [x] ✅: The function/method and its test have been added to the correct
-
- [x] ✅: The PR only contains changes relevant to the addressed subtask.
@theRealBird @hmahmood24 I have rebased the current branch with the latest patches in master and have also updated the task list to the best of my knowledge ...please take another look at this. Thanks a lot !
Hey @arshPratap, The PR looks good to me! Thanks a lot for contributing to Ivy. I do have a request. Before we merge this, could you please resolve the merge conflicts? Thanks!
Hey @arshPratap, The PR looks good to me! Thanks a lot for contributing to Ivy. I do have a request. Before we merge this, could you please resolve the merge conflicts? Thanks!
Done ! @theRealBird thanks for your review. I have rebased the branch with master
. PTAL .Thanks again !
@theRealBird have rebased it to the latest changes on master
branch . Can this be merged now
Hi @arshPratap, I still see that there are some conflicting files here. Could you have a look please? Thank you for your patience
@theRealBird sorry for the delay ! Have rebased to the latest commits ! Please take another look. Thanks
@theRealBird have made the changes you requested .. would love to hearback on any thoughts you have regarding this PR.Thanks
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.
@theRealBird So sorry for the delay..I have rebased the PR to the current changes in the master..Please take a look.Thanks again
Hey @arshPratap, I am sorry for the delay at my end too. Not sure how this skipped under my radar. Could you please take care of the conflicts one last time (hopefully)? I will be careful to merge it in time. Thanks!
@theRealBird rebase done !!
@theRealBird thanks for the review and so sorry for the late reply..lemme work on the failing tests and I will update the thread here regarding the same. Thanks
@theRealBird fixed the tests..seems that there are some datatypes that are not compatible with paddle (unsigned integers being the case) ..i had to remove the "valid"
and "numeric"
data types and replace them. Doing this has fixed the floating point tests that were failing.Please take a look
Thanks
@theRealBird rebased
@theRealBird ...the tests have been completed ..seems like the is_floating_point tests are not failing anymore..can this be merged now ?