ivy icon indicating copy to clipboard operation
ivy copied to clipboard

added_paddle_random_randperm

Open Unicorncosmos opened this issue 2 years ago • 2 comments

randperm Close #17687

Unicorncosmos avatar Jun 26 '23 05:06 Unicorncosmos

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you :hugs:

ivy-leaves avatar Jun 26 '23 05:06 ivy-leaves

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

ok

Unicorncosmos avatar Jun 26 '23 07:06 Unicorncosmos

@Unicorncosmos Thank you for your contribution and sorry for the lateness, I'm going to review it soon 🙂

MuhammedAshraf2020 avatar Jul 04 '23 12:07 MuhammedAshraf2020

@Unicorncosmos Thank you for your contribution and sorry for the lateness, I'm going to review it soon 🙂

ok

Unicorncosmos avatar Jul 04 '23 12:07 Unicorncosmos

@MuhammedAshraf2020 what is the progress of the review?

Unicorncosmos avatar Jul 10 '23 14:07 Unicorncosmos

@Unicorncosmos thanks for your PR. However, I can see that there are few errors being raised by your code. Could you please rectify them, and kindly try testing the code on local using PyTest if you aren't doing it already. Looking forward to the resolved code, and feel free to ping me once the code is ready for review.

satakshigarg avatar Jul 11 '23 21:07 satakshigarg

@Unicorncosmos thanks for your PR. However, I can see that there are few errors being raised by your code. Could you please rectify them, and kindly try testing the code on local using PyTest if you aren't doing it already. Looking forward to the resolved code, and feel free to ping me once the code is ready for review.

Ok

Unicorncosmos avatar Jul 12 '23 02:07 Unicorncosmos

why the resolve conflicts button is disabled

Unicorncosmos avatar Jul 16 '23 14:07 Unicorncosmos

Hi is there any update regarding above

Unicorncosmos avatar Jul 21 '23 18:07 Unicorncosmos

why the resolve conflicts button is disabled

The button has been disabled for everyone, and it says you need to resolve conflicts using CLI. So please try resolving conflicts on your local system using CLI. Hope that helps !!

satakshigarg avatar Jul 26 '23 13:07 satakshigarg

why the resolve conflicts button is disabled

The button has been disabled for everyone, and it says you need to resolve conflicts using CLI. So please try resolving conflicts on your local system using CLI. Hope that helps !!

Ok

Unicorncosmos avatar Jul 26 '23 16:07 Unicorncosmos

@Unicorncosmos Could you please share any updates, if there's any ? Let me know if you are facing any difficulties. Unfortunately, the resolve conflicts can be resolved only on your local system for this PR. Apologies for the inconvenience. Thanks & Keep contributing 😃

satakshigarg avatar Aug 12 '23 18:08 satakshigarg

@Unicorncosmos Could you please share any updates, if there's any ? Let me know if you are facing any difficulties. Unfortunately, the resolve conflicts can be resolved only on your local system for this PR. Apologies for the inconvenience. Thanks & Keep contributing 😃

Ok I will update it soon

Unicorncosmos avatar Aug 14 '23 11:08 Unicorncosmos

@satakshigarg I have resolved the conflicts.

Unicorncosmos avatar Sep 17 '23 19:09 Unicorncosmos

Hi any update on this pr

Unicorncosmos avatar Oct 01 '23 17:10 Unicorncosmos

@RickSanchezStoic any update on this pr.

Unicorncosmos avatar Oct 02 '23 10:10 Unicorncosmos

Hi @Unicorncosmos! Thanks for your contribution :smile: I see that you need help with your code and sorry for the delay on an answer. First I would advise you to solve the conflicts of your fork updating with the master branch. It can be done by saving the modifications you made in another folder, solving the conflicts of your fork, cloning again the fork and inserting the modification in the new copy of your fork.

Then, I would like to warn you about the files you modified. According to the ToDo list of issues the issue you are trying to solve came from, only two files must be modified:

  • ivy/functional/frontends/paddle/random.py
  • ivy_tests/test_ivy/test_frontends/test_paddle/test_random.py

Please do not modify other files than these.

The second problem I can see in your code is the git merging comments that are left in your code. They should not be there for your code to run properly. you can see them in the comments I left in the files.

Please check for these errors and then make sure the frontend function is written accordingly with the contributor guides that can be found on the Ivy Documentation and the test are not just following the same required patterns but also pass.

joaozenobio avatar Jan 16 '24 21:01 joaozenobio

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Feb 20 '24 05:02 ivy-seed

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Mar 01 '24 05:03 ivy-seed