ivy icon indicating copy to clipboard operation
ivy copied to clipboard

added quantile to numpy frontend

Open Chinemelu4 opened this issue 2 years ago • 3 comments

Close #17694

Chinemelu4 avatar Jun 24 '23 12:06 Chinemelu4

Hi @Chinemelu4, Thank you for your contribution to Ivy! In the current implementation, there are some arguments which are not being used such as method and overwrite_input.

I also request you to write a corresponding testing function for quantile. It is important to implement the test of every new frontend function we define so that we know it is working correctly.

Thank you

theRealBird avatar Jun 29 '23 05:06 theRealBird

Would update the PR with your corrections. Thanks

On Thu, Jun 29, 2023 at 6:35 AM theRealBird @.***> wrote:

Hi @Chinemelu4 https://github.com/Chinemelu4, Thank you for your contribution to Ivy! In the current implementation, there are some arguments which are not being used such as method and overwrite_input.

I also request you to write a corresponding testing function for quantile. It is important to implement the test of every new frontend function we define so that we know it is working correctly.

Thank you

— Reply to this email directly, view it on GitHub https://github.com/unifyai/ivy/pull/17701#issuecomment-1612457572, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS3FDRSYGJUGXSI64GJESFDXNUH2XANCNFSM6AAAAAAZSP6DMA . You are receiving this because you were mentioned.Message ID: @.***>

-- Aka Ezinwanne

Data Scientist

DataLab Analytics +2347013854987 Click: LinkedIN https://www.linkedin.com/in/ezinwanne-chinemelu-aka/ | Github https://github.com/Chinemelu4

Chinemelu4 avatar Jun 29 '23 06:06 Chinemelu4

Would update the PR with your corrections. Thanks On Thu, Jun 29, 2023 at 6:35 AM theRealBird @.> wrote: Hi @Chinemelu4 https://github.com/Chinemelu4, Thank you for your contribution to Ivy! In the current implementation, there are some arguments which are not being used such as method and overwrite_input. I also request you to write a corresponding testing function for quantile. It is important to implement the test of every new frontend function we define so that we know it is working correctly. Thank you — Reply to this email directly, view it on GitHub <#17701 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS3FDRSYGJUGXSI64GJESFDXNUH2XANCNFSM6AAAAAAZSP6DMA . You are receiving this because you were mentioned.Message ID: @.>

Hello, I would appreciate a bit of direction with the test I have written. It still fails and I have not been able to identify the cause. Thanks

Chinemelu4 avatar Jun 29 '23 12:06 Chinemelu4

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Jul 14 '23 05:07 ivy-seed

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Jul 31 '23 05:07 ivy-seed